blog: add release post for 8.0.0 #1241

jasnell · 2017-05-30T02:28:47Z

@cjihrig @mcollina @nodejs/ctc @ZibbyKeaton ... here's the draft. PTAL

Trott · 2017-05-30T02:47:04Z

locale/en/blog/release/v8.0.0.md

+
+The next major release of Node.js brings a range of significant changes and
+additions, far too many for us to cover adequately in a blog post such as this.
+This article contains a summary of the changes and details we feel are the most


Nit: Simplify:

This article contains a summary of the most significant changes and features.

Trott · 2017-05-30T02:48:56Z

locale/en/blog/release/v8.0.0.md

+without causing significant breakage.
+
+Zero-filling new instances of `Buffer(num)` by default will have a noticeable
+and significant impact on application performance. To mitigate the loss in


Nit: noticeable and significant -> significant; application performance -> performance

Trott · 2017-05-30T02:50:04Z

locale/en/blog/release/v8.0.0.md

+
+Zero-filling new instances of `Buffer(num)` by default will have a noticeable
+and significant impact on application performance. To mitigate the loss in
+performance, developers should move to the new `Buffer.allocUnsafe(num)` API if


Nit: Remove To mitigate the loss in performance

Trott · 2017-05-30T02:52:32Z

locale/en/blog/release/v8.0.0.md

+```
+
+Note that while the `Buffer(num)` constructor will not be removed from Node.js,
+its continued use is considered to be unsupported.


At a minimum: considered to be unsupported -> deprecated

But really, I'd say remove this sentence altogether. We can't truly guarantee that it will not be removed from Node.js ever (although I agree it's unlikely).

Trott · 2017-05-30T02:52:59Z

locale/en/blog/release/v8.0.0.md

+### Pending Deprecations
+
+To make it easier to catch uses of `Buffer(num)` within an application at
+development time, or within CI testing environments, a new


Nit: remove comma after time (but leave the one after environments)

Trott · 2017-05-30T02:56:18Z

locale/en/blog/release/v8.0.0.md

+line replacement, `node-inspect` has been integrated directly into the Node.js
+runtime. Additionally, the V8 Inspector debugger, which arrived previously as
+an experimental feature in Node.js 6, is being upgraded to an fully supported
+feature.


an fully supported -> a fully supported

I think this paragraph is a fair bit too wordy. Something succinct might be better. Maybe drop a couple sentences so it looks like this?:

The legacy command line debugger is being removed in Node.js 8. As a command
line replacement, node-inspect has been integrated directly into the Node.js
runtime. Additionally, the V8 Inspector debugger, which arrived previously as
an experimental feature in Node.js 6, is being upgraded to a fully supported
feature.

Trott · 2017-05-30T02:57:18Z

locale/en/blog/release/v8.0.0.md

+versions of the V8 JavaScript runtime, but Microsoft's Chakra-Core runtime
+as well.
+
+The [N-API](https://nodejs.org/api/n-api.html) is still considered experimental


Nit: Remove considered. (It's either experimental or it's not. Rather than provide clarity, 'considered' just muddies things.)

Trott · 2017-05-30T02:57:40Z

locale/en/blog/release/v8.0.0.md

+session.disconnect();
+```
+
+Note that the inspector API is still considered experimental and may change


Nit: remove still considered

Trott · 2017-05-30T02:58:33Z

locale/en/blog/release/v8.0.0.md

+
+### Long Term Support
+
+As an even numbered release, Node.js 8.0.0 represents the next release line to


Nit: Remove As an even numbered release,

Nit: represents -> is

Trott · 2017-05-30T02:58:46Z

locale/en/blog/release/v8.0.0.md

+### Long Term Support
+
+As an even numbered release, Node.js 8.0.0 represents the next release line to
+enter Long Term Support (LTS). This is scheduled to happen in October, once the


October -> October 2017

Trott · 2017-05-30T02:59:20Z

locale/en/blog/release/v8.0.0.md

+
+As an even numbered release, Node.js 8.0.0 represents the next release line to
+enter Long Term Support (LTS). This is scheduled to happen in October, once the
+Node.js 8 release line has had several months to completely stabilize. Once


Nit: Remove once the Node.js 8 release line has had several months to completely stabilize

Trott · 2017-05-30T03:00:16Z

locale/en/blog/release/v8.0.0.md

+![Node.js Long Term Support Schedule](https://talks.continuation.io/nodeweek-4-17/images/lts.png)
+
+If you’ve been using Node.js for any significant amount of time, it is worth
+noting that we’ve also dropped the “v” in Node.js 8. Previous versions  were


Nit: Change first sentence in this paragraph to Note that we have dropped the "v" in Node.js 8.

Trott · 2017-05-30T03:00:43Z

locale/en/blog/release/v8.0.0.md

+If you’ve been using Node.js for any significant amount of time, it is worth
+noting that we’ve also dropped the “v” in Node.js 8. Previous versions  were
+commonly referred to as v0.10, v0.12, v4, v6, etc. In order to avoid confusion
+with V8, the underlying JavaScript engine, we’ve decided to simply drop the “v”


we've decided to simply drop -> we've dropped

Trott

Left a bunch of nits, but overall: Wow, this is a lot to summarize and you've organized it well. 👍

jasnell · 2017-05-30T16:36:57Z

Updated to address the comments. Will update again once the release is out.

Trott · 2017-05-30T17:15:18Z

/cc @nodejs/documentation

mhdawson

LGTM

vsemozhetbyt · 2017-05-30T17:49:19Z

locale/en/blog/release/v8.0.0.md

+
+readfile('/some/file')
+  .then((data) => { /** ... **/ })
+  .catch((err) => { /** ... **/ }) ;


A nit: unnecessary space before semicolon.

vsemozhetbyt · 2017-05-30T17:53:49Z

locale/en/blog/release/v8.0.0.md

+Node.js processes.
+
+```js
+const inspector = require(‘inspector’);


Wrong quotes, parsing error.

vsemozhetbyt · 2017-05-30T17:55:05Z

locale/en/blog/release/v8.0.0.md

+session.connect();
+
+// Listen for inspector events
+session.on(‘inspectorNotification’, (message) => /** ... **/);


Wrong quotes, parsing error.

Maybe (message) => { /** ... **/ } ?

also funny quotes on require(‘inspector’)

It seems they are also fixed)

jasnell · 2017-05-30T18:59:39Z

Landed with fixes made. Thank you all

lpinca · 2017-05-30T19:04:24Z

@jasnell I think you only pushed on your fork.

jasnell · 2017-05-30T19:12:07Z

I need a beer. fixing

PR-URL: #1241

vsemozhetbyt · 2017-05-30T19:34:23Z

Sorry, is this OK:

Information for static error codes can be queried quickly by referencing the Node.js documentation. For instance, the URL to lookup information about the ERR_ASSERTION error code is https://nodejs.org/dist/latest-v7.x/docs/api/errors.html#ERR_ASSERTION.

Should this be ...latest-v7.x...? And there is no ERR_ASSERTION still in the https://github.com/nodejs/node/blob/master/doc/api/errors.md, so the link is wrong both for v7 and v8.

vsemozhetbyt · 2017-05-30T19:46:18Z

Processing warnings such as deprecations may now to redirected to a file

to redirected -> be redirected ?

vsemozhetbyt · 2017-05-30T20:10:19Z

The npm client has been updated to 5.0.0 [3c3b36af0f] #12936.

These are links for the beta, maybe they should be the nodejs/node@c58cea5 and nodejs/node#13276 instead.

vsemozhetbyt · 2017-05-30T20:25:14Z

NODE_MODULE_VERSION has been updated to 57 (nodejs/node@ec7cbaf266)] #12995.

Wrong link formatting, wrong (not shortened) rendering in the https://nodejs.org/en/blog/release/v8.0.0/

See also nodejs/node#13313

vsemozhetbyt · 2017-05-30T20:48:33Z

Maybe it is too late for this, but should not we mention in notable changes some cli changes versus v6, like:

nodejs/node#12028
nodejs/node#13012
nodejs/node#10651

vsemozhetbyt · 2017-05-30T20:51:10Z

@jasnell , @Trott , @nodejs/documentation
Sorry for being so late. Can we still fix the last nits? I am not sure about some of them and about the procedure now.

Trott · 2017-05-30T23:11:51Z

I am not sure about some of them and about the procedure now.

Procedure might be to open a pull request to make the changes. /cc @nodejs/website in case I'm wrong about that...

vsemozhetbyt · 2017-05-30T23:12:26Z

@Trott PTAL: #1244

jasnell · 2017-05-30T23:13:08Z

@vsemozhetbyt ... no problems :-) we can make edits to the blog post. Just add commits to the PR I see you've already opened :-)

ChALkeR · 2017-06-02T11:04:20Z

locale/en/blog/release/v8.0.0.md

+
+Zero-filling new instances of `Buffer(num)` by default will have a significant
+impact on performance. Developers should move to the new
+`Buffer.allocUnsafe(num)` API if they wish to allocate `Buffer` instances


This probably should have also mentioned Buffer.alloc (for consistent behaviour between versions), and an additional warning against using uninitialized memory allocations.

@jasnell, would it be acceptable to update the release post now? If yes, I will be willing to propose a small patch.

jasnell changed the title ~~blog: add release post for 8.0.0~~ [WIP] blog: add release post for 8.0.0 May 30, 2017

Trott reviewed May 30, 2017

View reviewed changes

mcollina approved these changes May 30, 2017

View reviewed changes

cjihrig approved these changes May 30, 2017

View reviewed changes

amandeepmittal approved these changes May 30, 2017

View reviewed changes

jasnell force-pushed the 8.0.0-release branch from d16c47f to e039a2b Compare May 30, 2017 16:14

mhdawson approved these changes May 30, 2017

View reviewed changes

vsemozhetbyt reviewed May 30, 2017

View reviewed changes

jasnell force-pushed the 8.0.0-release branch from e039a2b to 0c58f8e Compare May 30, 2017 18:54

jasnell changed the title ~~[WIP] blog: add release post for 8.0.0~~ blog: add release post for 8.0.0 May 30, 2017

blog: add release post for 8.0.0

eb81d8c

jasnell force-pushed the 8.0.0-release branch from 0c58f8e to eb81d8c Compare May 30, 2017 18:57

jasnell closed this May 30, 2017

jasnell added a commit that referenced this pull request May 30, 2017

blog: add release post for 8.0.0

9ef6161

PR-URL: #1241

vsemozhetbyt mentioned this pull request May 30, 2017

doc: fix nits in blog/release/v8.0.0.md #1244

Merged

ChALkeR reviewed Jun 2, 2017

View reviewed changes


		### Long Term Support

		As an even numbered release, Node.js 8.0.0 represents the next release line to

blog: add release post for 8.0.0 #1241

blog: add release post for 8.0.0 #1241

Conversation

jasnell commented May 30, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Trott left a comment

Choose a reason for hiding this comment

jasnell commented May 30, 2017

Trott commented May 30, 2017

mhdawson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jasnell commented May 30, 2017

lpinca commented May 30, 2017

jasnell commented May 30, 2017

vsemozhetbyt commented May 30, 2017 • edited Loading

vsemozhetbyt commented May 30, 2017

vsemozhetbyt commented May 30, 2017 • edited Loading

vsemozhetbyt commented May 30, 2017 • edited Loading

vsemozhetbyt commented May 30, 2017 • edited Loading

vsemozhetbyt commented May 30, 2017

Trott commented May 30, 2017

vsemozhetbyt commented May 30, 2017

jasnell commented May 30, 2017

Choose a reason for hiding this comment

vsemozhetbyt commented May 30, 2017 •

edited

Loading

vsemozhetbyt commented May 30, 2017 •

edited

Loading

vsemozhetbyt commented May 30, 2017 •

edited

Loading

vsemozhetbyt commented May 30, 2017 •

edited

Loading