-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformat of blog posts #154
Conversation
would you mind posting a screenshot of what's changed? |
Sure - no problem - I've attached to this message. On 15 September 2015 at 07:53, Rod Vagg notifications@github.com wrote:
|
didn't come through, if you go to github you can do it in the comment box and they'll appear inline |
That's much nicer than the current simple list, good work! A couple of suggestions from me (I'm not on the website team so will defer to them, perhaps they don't agree):
|
+1 to remove bullets, the heading styling is enough to imply a new article. {{title}} - {{date}} makes sense to me as the title is the primary information. |
Looks really sweet! For semantics, we should stick to We should also find a way to break the blog index list down into one page per year. Otherwise the list will be way too long. I don't have much time right now, so if anybody has a good idea how to handle this … |
Love it. |
Does this always guarantee to split on whitespace for where it ends the summary? Also could we add an ellipsis character to the end of the summary, before the link? ( |
@elinnet I'd love to merge your PR. Can you please have a quick look at the merge conflicts? |
I'm inclined to resolving the merge conflict manually, as this looks so much better than what we've got on nodejs.org atm 😄 |
@phillipj Knock yourself out. 😄 |
A 5 line summary of the blog post has been created to help users navigate useful blogposts. A 'read more' link has also been added