Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat of blog posts #154

Closed
wants to merge 3 commits into from
Closed

Reformat of blog posts #154

wants to merge 3 commits into from

Conversation

elinnet
Copy link
Contributor

@elinnet elinnet commented Sep 15, 2015

A 5 line summary of the blog post has been created to help users navigate useful blogposts. A 'read more' link has also been added

@rvagg
Copy link
Member

rvagg commented Sep 15, 2015

would you mind posting a screenshot of what's changed?

@elinnet
Copy link
Contributor Author

elinnet commented Sep 15, 2015

Sure - no problem - I've attached to this message.

On 15 September 2015 at 07:53, Rod Vagg notifications@github.com wrote:

would you mind posting a screenshot of what's changed?


Reply to this email directly or view it on GitHub
#154 (comment)
.

@rvagg
Copy link
Member

rvagg commented Sep 15, 2015

didn't come through, if you go to github you can do it in the comment box and they'll appear inline

@elinnet
Copy link
Contributor Author

elinnet commented Sep 15, 2015

Hi - I've attached the screnshot below

screen shot 2015-09-15 at 07 59 16

@rvagg
Copy link
Member

rvagg commented Sep 15, 2015

That's much nicer than the current simple list, good work!

A couple of suggestions from me (I'm not on the website team so will defer to them, perhaps they don't agree):

  • let's remove the <ul> completely, the dots seem pointless now
  • Include the date in the link or switch them so the date comes second, there's something that feels odd about the dates leading

@iancrowther
Copy link
Contributor

+1 to remove bullets, the heading styling is enough to imply a new article.

{{title}} - {{date}} makes sense to me as the title is the primary information.

@fhemberger
Copy link
Contributor

Looks really sweet!

For semantics, we should stick to <ul> (because it's a list of items), but we can remove the bullet.

We should also find a way to break the blog index list down into one page per year. Otherwise the list will be way too long. I don't have much time right now, so if anybody has a good idea how to handle this …

@mikeal
Copy link
Contributor

mikeal commented Sep 15, 2015

Love it.

@Fishrock123
Copy link
Contributor

Does this always guarantee to split on whitespace for where it ends the summary?

Also could we add an ellipsis character to the end of the summary, before the link? ()

@fhemberger
Copy link
Contributor

@elinnet I'd love to merge your PR. Can you please have a quick look at the merge conflicts?

@phillipj
Copy link
Member

phillipj commented Oct 5, 2015

I'm inclined to resolving the merge conflict manually, as this looks so much better than what we've got on nodejs.org atm 😄

@fhemberger
Copy link
Contributor

@phillipj Knock yourself out. 😄

@phillipj
Copy link
Member

phillipj commented Jan 2, 2016

These changes, with some additions, just landed in cbeb2a0, thanks @elinnet and @xicombd!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants