Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Discussion" to "Community Discussion" #1592

Merged
merged 3 commits into from
Apr 9, 2018

Conversation

bnb
Copy link
Contributor

@bnb bnb commented Mar 14, 2018

Per a discussion in the Moderation team meeting today, changing "Discussion" to "Community Discussion" enables a little bit more of a permissive and clear definition to what is included in this section.

cc @hackygolucky @nodejs/moderation

Per a discussion in the Moderation team meeting today, changing "Discussion" to "Community Discussion" enables a little bit more of a permissive and clear definition to what is included in this section.

cc @hackygolucky @nodejs/moderation
@thom4parisot thom4parisot requested review from fhemberger and removed request for fhemberger March 14, 2018 18:35
@fhemberger
Copy link
Contributor

fhemberger commented Mar 14, 2018

/cc
@nodejs/nodejs-es - Discusión comunidad
@nodejs/nodejs-fr - Discussion communauté
@nodejs/nodejs-uk - спільноти Обговорення
Catalan - Discussió comunitat

Can you please confirm my Google Translate powers? 😉

@yoannmoinet
Copy link

For the French one I'd say something like "Discussion de la communauté".

Or "Discussion communautaire" that I like a little less though.

I'll let my fellow French friends have another opinion on this.

@cedced19
Copy link
Contributor

Yes "Discussion de la communauté" seems to be good after a little reflection.

@academo
Copy link
Contributor

academo commented Mar 14, 2018

For Spanish I would go for something like "Discusiones de la comunidad" or "Discusión de la comunidad". The last one (singular) sounds a bit weird for me because sounds like only one discussion is going on.

Other Spanish speakers may as well confirm if they agree with it.

@bithavoc
Copy link

@academo how about Discusión Comunitaria for Spanish

@academo
Copy link
Contributor

academo commented Mar 14, 2018

@bithavoc that sounds very good indeed.

@Tsuna-mi
Copy link
Contributor

For spanish seems good to me 'Discusión de la comunidad'
and for catalan 'Discussió de la comunitat'

@hackygolucky
Copy link
Contributor

Will approve once the other language markdown is added!

@fhemberger
Copy link
Contributor

@bnb Can you please update the PR with the translations?

@fhemberger
Copy link
Contributor

Updated the translations, @bnb @hackygolucky, can this be merged now?
(BTW: I didn't change the Ukrainian translation, leave this to @nodejs/nodejs-uk.)

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Apr 9, 2018

As for Ukrainian translation: ## Обговорення -> ## Громадське обговорення seems OK.

@fhemberger
Copy link
Contributor

@vsemozhetbyt Thanks, added!

@bnb
Copy link
Contributor Author

bnb commented Apr 9, 2018

Looks like this can be updated, apologies for not getting back to this sooner @fhemberger!

@fhemberger fhemberger merged commit 47288bc into master Apr 9, 2018
@fhemberger
Copy link
Contributor

Ok, merged.

@fhemberger fhemberger deleted the bnb/community-discussion branch April 9, 2018 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants