-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add NODE_MODULE_VERSION column to the releases table #160
Conversation
@maxogden Correct me if I'm wrong, but isn't this better covered by https://nodejs.org/dist/index.json? |
Perhaps we should link to that json on this page? |
@Fishrock123 the data you linked is that data that is used to render the table, so it's the same thing |
@maxogden see also nodejs/build#151 which is related to your gist |
lgtm, I quite like the idea of this number becoming part of user-base consciousness as it's pretty important |
Can someone please add a little note on the table, what "NODE_MODULE_VERSION" is supposed to mean? Have you checked the table layout on small screens as well? |
we could just call it "modules version", that'd be consistent enough:
|
Or just "Modules", it seems confusing but with a footnote it might make sense:
|
@rvagg 👍 |
Rod's comment seems good. |
@@ -3,4 +3,5 @@ layout: download-releases.hbs | |||
title: Previous Releases | |||
iojs: | |||
intro: "Releases 1.x through 3.x were called \"io.js\" as they were part of the io.js fork. As of Node.js 4.0.0 the former release lines of io.js converged with Node.js 0.12.x into unified Node.js releases." | |||
modules: "\"Modules\" refers to the ABI (application binary interface) version number of Node.js, used to determine which versions of Node.js compiled C++ add-on binaries can be loaded in to without needing to be re-compiled. This version number is also referred to as NODE_MODULE_VERSION." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NODE_MODULE_VERSION
.
Might render better. (Also: period.) :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Fishrock123 the period is in the diff, not in the screenshot sorry. Heres what it looks like wrapped with a <code>
:
And without (the current version in the branch now):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better with <code>
IMHO. Let's get this merged. ;)
alright, updated. should be good to go |
add NODE_MODULE_VERSION column to the releases table
Yaaay! Thank you! ^____^ |
great work! I love that this is first-class, thanks @maxogden |
why this is valuable: https://gist.github.com/maxogden/e81e0f1d222106146828
what it looks like: