Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Debugging Guide and Inspector Help #1610

Merged
merged 1 commit into from
Apr 2, 2018
Merged

Merge Debugging Guide and Inspector Help #1610

merged 1 commit into from
Apr 2, 2018

Conversation

fhemberger
Copy link
Contributor

Fixes #1609

@fhemberger fhemberger mentioned this pull request Mar 30, 2018
Closed
@fhemberger fhemberger requested a review from ofrobots March 30, 2018 06:27
marswong
marswong reviewed Mar 30, 2018
View reviewed changes
Copy link
Contributor

@marswong marswong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should inspector.md be removed?

@fhemberger
Copy link
Contributor Author

@marswong Yes, once the redirect is in place.

@fhemberger fhemberger merged commit a0d5211 into master Apr 2, 2018
@fhemberger fhemberger deleted the fix/inspector branch April 2, 2018 22:55
@zackurben zackurben mentioned this pull request Apr 3, 2018
Closed
@fhemberger fhemberger mentioned this pull request Apr 5, 2018
Merged
rvagg pushed a commit to nodejs/build that referenced this pull request Apr 5, 2018
@fhemberger @rvagg
nginx: Redirect old inspector docs (#1214)
9b7ac9e 
Ref: nodejs/nodejs.org#1610
@fhemberger fhemberger mentioned this pull request Apr 5, 2018
Merged
rvagg pushed a commit to nodejs/build that referenced this pull request Apr 5, 2018
@fhemberger @rvagg
nginx: Redirect old inspector docs (#1215)
06a168e 
Ref: nodejs/nodejs.org#1610
This was referenced Apr 5, 2018
Merged
Closed
rvagg pushed a commit to nodejs/build that referenced this pull request Apr 9, 2018
@fhemberger @rvagg
nginx: Redirect old inspector docs (node executable) (#1219)
d62e636 
* nginx: Redirect old inspector docs

Ref: nodejs/nodejs.org#1610

* nginx: Redirect old inspector docs (node executable)

Turns out node was linking to https://nodejs.org/en/docs/inspector.
This fixes the redirect as well.

Ref: nodejs/nodejs.org#1619
@outsideris outsideris mentioned this pull request Dec 16, 2018
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 24, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Apr 21, 2022
Open
@NOUIY NOUIY mentioned this pull request Apr 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckotzbauer ckotzbauer ckotzbauer approved these changes

@marswong marswong marswong approved these changes

@WaleedAshraf WaleedAshraf WaleedAshraf approved these changes

@daxlab daxlab daxlab approved these changes

@hiroppy hiroppy hiroppy approved these changes

@ofrobots ofrobots ofrobots approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fhemberger @ofrobots @hiroppy @daxlab @WaleedAshraf @marswong @ckotzbauer