Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove banner #1632

Merged
merged 1 commit into from
Apr 21, 2018
Merged

remove banner #1632

merged 1 commit into from
Apr 21, 2018

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 21, 2018

The banner for the March 2018 security updates has been up for many
weeks now. Not sure if there's a policy on how long to leave it up for,
but it seems that by having it there all the time, we encourage people
to not notice when the text changes to from "Important March 2018
security upgrades now available" to (say) "Important May 2018 security
upgrades now available". At least, that's my thinking...

The banner for the March 2018 security updates has been up for many
weeks now. Not sure if there's a policy on how long to leave it up for,
but it seems that by having it there all the time, we encourage people
to not notice when the text changes to from "Important March 2018
security upgrades now available" to (say) "Important May 2018 security
upgrades now available". At least, that's my thinking...
@fhemberger fhemberger merged commit 81ecf25 into nodejs:master Apr 21, 2018
@fhemberger
Copy link
Contributor

👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants