-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contributor-list/package-lock.json. #1639
Conversation
This updates hoek@2 to hoek@4.2.1.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just ran the script without any error with these steps.
- Pulled latest
npm install
GITHUB_API_TOKEN=<your token> node index.js <since date: YYYY-MM-DD>
@WaleedAshraf It's in package-lock.json, not package.json, because it's a dependency of a dependency. |
👍 Thanks! |
(For what it's worth, those are the steps I took and it seemed to take a looooong time. Maybe I just wasn't patient enough? I think I waited a minute or two.) |
Maybe something with the date. What date you used? |
@Trott Yes, it's still in use and it should work. ;) |
I'm going to guess it's my API token/account permissions. Regardless, as long as it is working, great. |
@Trott Why are there two PRs for this change? 🤔 |
@fhemberger One is for I think both can be closed? |
No, they should not be closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This updates hoek@2 to hoek@4.2.1.
I wasn't able to test the relevant script because it didn't work for me even with no changes. So, maybe someone else can confirm that it's still in use and that it works? (Maybe GitHub was having issues when I tried? I'm pretty sure my API token would have the needed permissions.)