Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bash code blocks to fix ampersand rendering #1661

Merged
merged 1 commit into from
May 22, 2018
Merged

Conversation

0mp
Copy link
Contributor

@0mp 0mp commented May 21, 2018

If sh is used instead of bash "&&" is displayed as "&&".

Fix #1660 (hopefully).

If sh is used instead of bash "&&" is displayed as "&&".

Fix nodejs#1660.
Copy link
Contributor

@WaleedAshraf WaleedAshraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@daxlab daxlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fhemberger can we land this ?

@fhemberger fhemberger merged commit e9d5828 into nodejs:master May 22, 2018
@fhemberger
Copy link
Contributor

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants