Update links to official Node.js Docker image #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @nodejs/docker PTAL. |
|
Since docker-library/official-images links to hub.docker.com and the promotion banner seems to be gone now, I’ve updated the links to hub.docker.com. |
sonicdoe
force-pushed
the
docker-official-image-link
branch
from
4bb3bc7 to
5b2dd20
Compare
|
@tianon any preference? |
|
We link to Hub (as noted above), and docker-library/official-images#4475 is somewhere we've recently explained why. 👍 |
fhemberger
approved these changes
Sep 12, 2018
This was referenced Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn’t entirely sure whether to update the links to hub.docker.com or store.docker.com. However, given the promotion on hub.docker.com (“node is now available in the Docker Store, the new place to discover public Docker content”), the Docker Store seems to be the way to go.