[Fix] Make the redirectToEnglishUrl behaves properly for local debugging
#1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Jul 4, 2018
marswong
approved these changes
Jul 4, 2018
server.js
Outdated
| @@ -35,27 +35,32 @@ const locales = chokidar.watch(path.join(__dirname, 'locale'), opts) | |||
| const layouts = chokidar.watch(path.join(__dirname, 'layouts'), opts) | |||
| const statics = chokidar.watch(path.join(__dirname, 'static'), opts) | |||
|
|
|||
| const OTHER_SUPPORTED_LANGS = new Set(['ar', 'ca', 'de', 'es', 'fr', 'gl', 'it', 'ja', 'ko', 'uk', 'zh-cn', 'zh-tw']) | |||
|
|
|||
There was a problem hiding this comment.
It'd be better to use fs to get the directories under locale instead of fixed values.
…gging According to the normal webside, we have 4 kinds of url forms: 1) https://localhost:8080/: Access the route, the default lang is `en`. 2) https://localhost:8080/zh-cn/docs/: If we don't have the proper translations, just direct you to `en`. 3) https://localhost:8080/zh-nc/docs/: If we have a wrong language, 404 will be returned. 4) https://localhost:8080/blog: When directly accessing a folder, just add `en` as the default lang. For other page routes, `404` will be redirected to you. So the original codes don't meet all these cases. Here's the fix for that.
|
@marswong ： Fixed, thanks! |
This was referenced Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fhemberger ：
According to the normal webside, we have 4 kinds of url forms:
en.translations, just direct you to
en.be returned.
enas the default lang (converted to
https://localhost:8080/en/blog).For other page routes,
404will be redirected to you.So the original codes don't meet all these cases. (e.g: https://localhost:8080/zh-cn/docs/, if you don't have doc translated files or folders, this will return you 404 instead of returning you a default
enpage).But according to the comment, it SHOULD return you a default
endoc files:)Here's the fix for that.