Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js Everywhere copy from weekly to monthly #1747

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

sonicdoe
Copy link
Contributor

Resolves #1745. The copy is updated on both the home page and the “Get Involved” page.

@daxlab
Copy link
Contributor

daxlab commented Jul 26, 2018

👍

@fhemberger
Copy link
Contributor

Great, now we need someone to check the other translations as well ... ;)

@sonicdoe
Copy link
Contributor Author

sonicdoe commented Jul 26, 2018

As an overview, the following strings would need to be updated:

newsletter-postfix in index.md:

  • Arabic (ar): , القائمة البريدية الأسبوعية الرسمية ل Node.js
  • Italian (it): , la newsletter settimanale di Node.js
  • Simplified Chinese (zh-cn): ,Node.js 官方的新闻周报。
  • Traditional Chinese (zh-tw): :Node.js 官方的新聞週報。

In get-involved/index.md:

  • French (fr): [Node.js Everywhere](https://newsletter.nodejs.org) est la newsletter hebdomadaire officielle de Node.js [en].
  • Traditional Chinese (zh-tw): [Node.js Everywhere](https://newsletter.nodejs.org) 是 Node.js 官方的週報。

@lpinca
Copy link
Member

lpinca commented Jul 28, 2018

For the Italian translation above you can use "la newsletter mensile di Node.js"

@sonicdoe
Copy link
Contributor Author

@lpinca Thank you 👍 I’ve changed it.

@fhemberger Should I mention the respective localization teams or should we just merge this as is and update the other languages as we go along?

@ghost
Copy link

ghost commented Jul 28, 2018

Thanks @sonicdoe,Please add this :)

【For zh-CN】
index.md:Node.js 官方的新闻月报。

【For zh-TW】
index.md:Node.js 官方的新聞月報。
get-involved/index.md:是 Node.js 官方的月報。

/cc:
@nodejs/nodejs-ja
@nodejs/nodejs-ar
@nodejs/nodejs-fr

I've also called these related translators to help to contribute their language translations here, you can copy and paste them when they are free to contribute.

@fhemberger
Copy link
Contributor

@sonicdoe Japanese version doesn't use the term "weekly" in their description at all as far as I can tell.

French should be "hebdomadaire" -> "mensuel".

@sonicdoe
Copy link
Contributor Author

sonicdoe commented Aug 3, 2018

@fhemberger Thanks, done 👍 Only Arabic left.

@thom4parisot
Copy link

@sonicdoe actually in French it should be mensuelle instead of mensuel, because the term newsletter is a feminine term (hence the le suffix).

@fhemberger
Copy link
Contributor

@oncletom Ahhhh, sorry for that!

@thom4parisot
Copy link

@fhemberger no probs at all! Thank you for taking care of this PR with @sonicdoe 🙂

@mermi
Copy link

mermi commented Aug 14, 2018

For the Arabic version if you need to say weekly newsletter about Node.js it should be:
الرسالة الإخبارية الأسبوعية عن Node.js
If you wanna say monthly newsletter about Node.js it should be:
الرسالة الإخبارية الشّهريّة عن Node.js

Let me know if you need further help 😃

Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
Co-authored-by: Maledong <40081831+Maledong@users.noreply.github.com>
Co-authored-by: Thomas Parisot <oncletom@users.noreply.github.com>
Co-authored-by: Manel Rhaiem <manel.rhaiem92@gmail.com>
@fhemberger
Copy link
Contributor

@mermi Awesome, thank you so much! 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants