Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize zh-cn translate #1793

Merged
2 commits merged into from
Sep 7, 2018
Merged

fix: optimize zh-cn translate #1793

2 commits merged into from
Sep 7, 2018

Conversation

paranoidjk
Copy link
Contributor

No description provided.

@paranoidjk
Copy link
Contributor Author

cc/ @Maledong

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect and thanks anyway!
But I don't think it needs translating comments in the code snippet, because we want to keep it origin.

So what you can do now is to restore all your tranlated comments from Chinese back to English, and the submit to the same PR. I'll try to merge or tell you if there's anything wrong.

Many thanks again for you GREAT help!

@@ -118,7 +119,7 @@ app.get('/constant-time', (req, res) => {
app.get('/countToN', (req, res) => {
let n = req.query.n;

// n iterations before giving someone else a turn
// 先执行 n 次循环,才给其他请求执行机会
Copy link

@ghost ghost Sep 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it needs translating comments in the original codes because we want to keep it in origin. So please restore the rest part into the original English instead of Chinese here, if you take a close look at others' translations :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine!
Wait for another one to approve and I'll do a merge.

@ghost
Copy link

ghost commented Sep 7, 2018

/cc: @nodejs/nodejs-cn, Have you any other suggestions? If no please agree again and I'll merge this.

@Lellansin
Copy link

LGTM

Copy link

@terry-fei terry-fei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ghost ghost merged commit ddd2298 into nodejs:master Sep 7, 2018
@ghost
Copy link

ghost commented Sep 7, 2018

@paranoidjk:Thanks for your contributions!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants