Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update profiling crypto example #1796

Merged
merged 1 commit into from
Sep 10, 2018

Conversation

trevorah
Copy link
Contributor

@trevorah trevorah commented Sep 4, 2018

The digest parameter is required as of v6.0.0, otherwise the example code errors out like this:

TypeError: The "digest" argument is required and must not be undefined
    at pbkdf2 (crypto.js:694:11)
    at Object.exports.pbkdf2Sync (crypto.js:687:10)

Details: https://nodejs.org/api/crypto.html#crypto_crypto_pbkdf2sync_password_salt_iterations_keylen_digest

The digest parameter is required as of v6.0.0
@vsemozhetbyt
Copy link
Contributor

сс @nodejs/crypto

@lpinca lpinca merged commit 185e154 into nodejs:master Sep 10, 2018
@lpinca
Copy link
Member

lpinca commented Sep 10, 2018

Thank you.

@ghost ghost mentioned this pull request Sep 13, 2018
ghost pushed a commit that referenced this pull request Sep 17, 2018
Ref: #1796.

Since the '/newUser' request is encoded by 'sha512', and your
corresponding '/auth' must also use 'sha512' as the digest encoding
as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants