nodejs-es: Sync site.json with english version #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR update locale/es/site.json file as its english version. Thanks for reviewing it! :) Related with #1778 cc @nodejs/nodejs-es
academo
reviewed
Oct 14, 2018
locale/es/site.json
Outdated
| } | ||
| }, | ||
| "getinvolved": { | ||
| "link": "get-involved", | ||
| "text": "Participa", |
There was a problem hiding this comment.
I think "Participa" makes more sense in this context rather than "Implícate"
There was a problem hiding this comment.
I tried it with 'implícate' cause is the word used at catalan translation. I can change in both files by 'Participa' to be consistent.
Thanks @academo
|
@Tsuna-mi Could you please check for merge conflicts? Would like to get this merged. |
@fhemberger Sorry I don't see conflicts.. I've fixed last week |
|
@Tsuna-mi Ok, may be related to GitHub's hiccup today. Please go ahead and merge this PR, I can't do it myself:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update locale/es/site.json file as its english version.
Thanks for reviewing it! :)
Related with #1778
cc @nodejs/nodejs-es