Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-CN: Trans for the 'node-meetups' and 'node-speakers' nodes in 'site.json' #2016

Merged
1 commit merged into from Jan 31, 2019
Merged

zh-CN: Trans for the 'node-meetups' and 'node-speakers' nodes in 'site.json' #2016

1 commit merged into from Jan 31, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 26, 2019

For the Chinese translation for 'node-meetups' and 'node-speakers'.

@ghost ghost requested a review from ZYSzys January 26, 2019 11:47
Copy link
Member

@ZYSzys ZYSzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉 meetup 翻译为 聚会 更合适一点吧。

locale/zh-cn/site.json Outdated Show resolved Hide resolved
@ZYSzys
Copy link
Member

ZYSzys commented Jan 27, 2019

IMHO, there are plenty of PRs for 'node-meetsup' and 'node-speakers' now, it seems to be difficult to catch up everything. How about leave it in English, or translate after most of those PRs merged ?

Copy link
Contributor

@willin willin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willin
Copy link
Contributor

willin commented Jan 29, 2019

agreed.

p.s. 像jsconf之类的都翻成“开发者大会

For the Chinese translation for 'node-meetups' and 'node-speakers'.
@ghost ghost changed the title zh-CN: Translation for 'node-meetsup' and 'node-speakers' zh-CN: Trans for the 'node-meetups' and 'node-speakers' nodes in 'site.json' Jan 31, 2019
@ghost ghost merged commit 53a26bf into nodejs:master Jan 31, 2019
@ghost ghost deleted the NewMeetsUpAndSpeakers branch January 31, 2019 11:41
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants