Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update the img link of 'schedule.svg' #2056

Merged
merged 1 commit into from Feb 9, 2019
Merged

Fix: Update the img link of 'schedule.svg' #2056

merged 1 commit into from Feb 9, 2019

Conversation

ghost
Copy link

@ghost ghost commented Feb 9, 2019

We cannot see the 'schedule.png', so according to this submit (nodejs/Release@2bf2ea3), it seems the img was removed and we've used 'schedule.svg' instead.

The reason why I use the parameter ?sanitize=true is that we MUST make sure that the response type should be of img (Content-Type should be img/svg+xml instead of text/plain).

For more about svg rendering on GitHub's server, please see these related posts:

  1. README rendering doesn't handle relative/local SVG images isaacs/github#316 (comment)
  2. https://stackoverflow.com/questions/13808020/include-an-svg-hosted-on-github-in-markdown

Fix for: #2055

@ghost ghost requested a review from fhemberger February 9, 2019 10:48
@ghost ghost changed the title Fix: Update the missing img of 'schedule.svg' Fix: Update the img link of 'schedule.svg' Feb 9, 2019
We cannot see the 'schedule.png', so according to this submit
(nodejs/Release@2bf2ea3), it seems the img was removed and we've used
'schedule.svg' instead.

The reason why I use the parameter `?sanitize=true` is that we MUST make
sure that the response type should be of img (Content-Type should be
`img/svg+xml` instead of `text/plain`).

For more about svg rendering on GitHub's server, please see these
related posts:

1. isaacs/github#316 (comment)
2.
https://stackoverflow.com/questions/13808020/include-an-svg-hosted-on-github-in-markdown
(See 'Linking to RAW files (Does not work)').

Fix for: #2055
@fhemberger fhemberger merged commit 0232462 into nodejs:master Feb 9, 2019
@ghost ghost deleted the FixSvgMissing branch February 10, 2019 01:40
ghost pushed a commit that referenced this pull request Feb 10, 2019
Since we've got an easy way to analyze the anchor link's name (See: #2056). We can write these titles in a union way. So remove pure HTML codes and write them together.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants