Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: add #28630 to "notable" section of v12.7.0 release #2353

Merged
merged 2 commits into from
Jul 27, 2019

Conversation

boneskull
Copy link
Contributor

@targos I don't know if it's typical to update this after-the-fact, but here it is in case you want to merge it. I think it's worth drawing attention to, anyway, because it will break people using the experimental "reports" API.

@targos
Copy link
Member

targos commented Jul 25, 2019

Could you revert the other changes? LGTM otherwise

@boneskull
Copy link
Contributor Author

oops. blame prettier

@boneskull
Copy link
Contributor Author

@targos this is updated

@Trott
Copy link
Member

Trott commented Jul 26, 2019

LGTM but maybe include what it used to be? It's returning an object instead of....

@targos
Copy link
Member

targos commented Jul 26, 2019

I updated the release entry: https://github.com/nodejs/node/releases/tag/v12.7.0
I modified the text to "Modify process.report.getReport() to return an Object instead of a JSON string"

@boneskull
Copy link
Contributor Author

LGTM

@targos targos merged commit fa2d413 into nodejs:master Jul 27, 2019
This was referenced Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants