fix: no-shortcut-reference-link #2697
Conversation
|
@nschonni can you fix tests and take care of my comment above? |
Since we're importing them from elsewhere, it may be best to simply skip linting on them entirely and enforce any lint rules we want upstream (or just don't worry about the linting for the changelogs). |
nschonni
force-pushed
the
fix--no-shortcut-reference-link
branch
3 times, most recently
from
bb32b11 to
37e923f
Compare
|
Although a bunch of the changelog related fixes have been applied upstream, i've just disabled the same rules plus this new one at the file level for the changlog blogs |
nschonni
force-pushed
the
fix--no-shortcut-reference-link
branch
from
37e923f to
3ebf376
Compare
| @@ -7,6 +7,10 @@ slug: node-v0-10-42 | |||
| layout: blog-post.hbs | |||
| author: James M Snell | |||
| --- | |||
| <!--lint disable prohibited-strings--> | |||
There was a problem hiding this comment.
Can you confirm such comments are not in the built HTML? Not a blocker, but we should be aware about it.
There was a problem hiding this comment.
Yes, it looks like it ends up the built HTML
| @@ -139,7 +139,7 @@ node --prof-process isolate-0xnnnnnnnnnnnn-v8.log > processed.txt | |||
| 3165 8.4% 8.6% _malloc_zone_malloc | |||
| ``` | |||
|
|
|||
| 我们看到，前 3 个条目占了程序占用的 CPU 时间的 72.1%。从这个输出中，我们立即看到至少 51.8% 的 CPU 时间被称为 PBKDF2 的函数占用。它与用户密码中的哈希生成相对应。然而，较低的两个条目的因素是如何进入我们的应用程序（或者我们为了例子而假装如此）不会立即明显得看出来。为了更好地理解这些函数之间的关系，接下来我们将查看[自下而上（重）配置文件]部分，该节提供有关每个函数的主要调用方的信息。检查此部分，我们会发现： | |||
| 我们看到，前 3 个条目占了程序占用的 CPU 时间的 72.1%。从这个输出中，我们立即看到至少 51.8% 的 CPU 时间被称为 PBKDF2 的函数占用。它与用户密码中的哈希生成相对应。然而，较低的两个条目的因素是如何进入我们的应用程序（或者我们为了例子而假装如此）不会立即明显得看出来。为了更好地理解这些函数之间的关系，接下来我们将查看\[自下而上（重）配置文件\]部分，该节提供有关每个函数的主要调用方的信息。检查此部分，我们会发现： | |||
There was a problem hiding this comment.
This is Chinese to me so I can't judge the change 😛
|
LGTM now, it needs a rebase and I left a couple of comments. I can approve after those are addressed 🙂 |
nschonni
force-pushed
the
fix--no-shortcut-reference-link
branch
from
3ebf376 to
7c4f3b1
Compare
|
Rebased. Confirmed that the |
No description provided.