Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source/schedule.json #2773

Closed
wants to merge 2 commits into from
Closed

Remove source/schedule.json #2773

wants to merge 2 commits into from

Conversation

XhmikosR
Copy link
Contributor

This file is grabbed on build time for production.

Just add a preserve script for local development.

Fixes #2767

@nodejs/website

BTW we could probably remove the serve script and use npm start only, since right now npm start just calls serve. It just needs some doc updates to reflect this later.

@XhmikosR XhmikosR requested a review from Trott November 14, 2019 16:28
@XhmikosR
Copy link
Contributor Author

Hmm, actually we need the same script for build and build:deploy

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Nov 14, 2019

Alright, I added 2 approaches. Let me know which one you prefer. I also changed build:deploy to call the build script to reduce duplication.

The only thing that we might need to do is document that curl is needed to be installed and in PATH. Even Windows 10 has it, and *nix should also have it.

@AyushG3112
Copy link
Contributor

Note that this does impact offline serves.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Nov 14, 2019

Well, of course :)

But as far as I see it

  1. either we keep updating the file manually
  2. have it as a prehook or something
  3. this patch
  4. live with it being outdated

The same applies for source/versions.json, but versions.json isn't used in build time AFAICT.

@Trott
Copy link
Member

Trott commented Dec 26, 2019

@XhmikosR Is this ready to land in your opinion?

@XhmikosR
Copy link
Contributor Author

It is ready AFAICT, we just need to decide which of the two ways to go with.

Also do keep in mind that this will require an internet connection to develop. I don't consider this an issue, but there might be cases this could cause trouble for some people.

This file is grabbed on build time for production.
@XhmikosR
Copy link
Contributor Author

XhmikosR commented Feb 3, 2020

I'm gonna close this since we haven't come to an agreement. I will push my fork's branch to the upstream repo in case we need it later.

@XhmikosR XhmikosR closed this Feb 3, 2020
@XhmikosR XhmikosR deleted the master-xmr-rm-schedule-json branch February 3, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove source/schedule.json?
5 participants