-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove source/schedule.json #2773
Conversation
Hmm, actually we need the same script for |
Alright, I added 2 approaches. Let me know which one you prefer. I also changed The only thing that we might need to do is document that |
Note that this does impact offline |
Well, of course :) But as far as I see it
The same applies for source/versions.json, but versions.json isn't used in build time AFAICT. |
@XhmikosR Is this ready to land in your opinion? |
It is ready AFAICT, we just need to decide which of the two ways to go with. Also do keep in mind that this will require an internet connection to develop. I don't consider this an issue, but there might be cases this could cause trouble for some people. |
This file is grabbed on build time for production.
I'm gonna close this since we haven't come to an agreement. I will push my fork's branch to the upstream repo in case we need it later. |
This file is grabbed on build time for production.
Just add a
preserve
script for local development.Fixes #2767
@nodejs/website
BTW we could probably remove the
serve
script and usenpm start
only, since right nownpm start
just callsserve
. It just needs some doc updates to reflect this later.