Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fnm Node.js version manager #3645

Merged
merged 8 commits into from
Feb 11, 2021
Merged

Add fnm Node.js version manager #3645

merged 8 commits into from
Feb 11, 2021

Conversation

wildcard
Copy link
Contributor

@wildcard wildcard commented Jan 20, 2021

fnm is an exciting trending Node.js version manager built in Rust & it is very fast

resolves Schniz/fnm#367

fnm is an exciting trending Node.js version manager built in Rust & is very fast
@@ -20,6 +20,7 @@ title: Installing Node.js via package manager
* [NetBSD](#netbsd)
* [Nodenv](#nodenv)
* [nvm](#nvm)
* [fnm](#fnm)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list is in case-insensitive alphabetical order, so this should be added after line 15 instead of here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry I missed the order logic, changing 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✅

Comment on lines 215 to 222
## fnm

Fast and simple Node.js version manager built-in Rust used to manage multiple released Node.js versions. It allows you to perform operations like install, uninstall, switch Node versions automatically based on the current directory, etc.
To install fnm, use this [install script](https://github.com/Schniz/fnm#using-a-script-macoslinux).

fnm has cross-platform support (macOS, Windows, Linux) & all poplar shells (Bash, Zsh, Fish, PowerShell, Windows Command Line Prompt)
it's built with speed in mind and compatibility support for `.node-version` and `.nvmrc` files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, the sections are in case-insensitive alphabetical order, so this should be added earlier in the document.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m on it 🙌

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✅

Co-authored-by: Rich Trott <rtrott@gmail.com>
Copy link
Contributor

@willin willin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wildcard
Copy link
Contributor Author

wildcard commented Jan 22, 2021

Thanks @Trott & @willin for the review and suggestions ❤️🙏

I'm merging now waiting for a merge

@Trott
Copy link
Member

Trott commented Feb 10, 2021

@nodejs/version-management PTAL

@ljharb
Copy link
Member

ljharb commented Feb 11, 2021

LGTM

@shadowspawn
Copy link
Member

A related PR for possible consideration while people are in the right mindset. I submitted a similar PR for n a while ago which is languishing:

#3300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fnm should be on the package manager list in Node.js site
8 participants