Events page auto-centers based on top 10 events #389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return a.dist > b.dist ? 1 : | ||
| a.dist < b.dist ? -1 : 0; | ||
| }) | ||
| var nearest = Array.isArray(points) && (points.length > 10 ? points.slice(0, 9) : points.slice(0, points.length-1)); |
There was a problem hiding this comment.
I don't think this safety is necessary because we're in the feature layer's onready, so points will always be an array and it'll always be huge (much more than 10) because we load the array from the giant geojson url.
There was a problem hiding this comment.
Ah yes, thx for spotting that. One sec...
justsml
force-pushed
the
events-top10
branch
from
f599011
to
d47e27c
Compare
|
Hopefully that looks better |
|
Hey @mikeal Hope you had a good thanksgiving. Did you notice my latest update? |
|
This looks great! I've merged locally and am modifying just a little bit. I realized that we also need a minimum threshold of distance so that when you're in a very dense area you don't get a hyper localized map. |
|
This was merged as part of b3efd13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @mikeal Here's a clean PR RE #382