improved grammar #4517
Merged
improved grammar #4517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed comma to parentheses to make it clear that what previously followed the comma is a side-note, not a separate statement with equal weight Changed "includes" to "also applies to" to remove grammatical ambiguity which allowed for the following interpretation: "strings can contain object properties"
Trott
reviewed
Mar 27, 2022
| @@ -65,7 +65,7 @@ There are a few rules to remember when dealing with data in JSON | |||
| format. There are several gotchas that can produce invalid JSON as well. | |||
|
|
|||
| * Empty objects and arrays are okay | |||
| * Strings can contain any unicode character, this includes object properties | |||
| * Strings can contain any unicode character (this also applies to object properties) | |||
There was a problem hiding this comment.
Suggested change
| * Strings can contain any unicode character (this also applies to object properties) | |
| * Strings can contain any unicode character. (This also applies to object properties.) |
|
I suspect we should remove this article entirely and replace it with a link to https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Objects/JSON. We really don't need to maintain a JSON tutorial. That's outside of the scope of the website. |
Trott
approved these changes
Mar 27, 2022
This was referenced Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed comma to parentheses to make it clear that what previously followed the comma is a side-note, not a separate statement with equal weight
Changed "includes" to "also applies to" to remove grammatical ambiguity which allowed for the following interpretation: "strings can contain object properties"