fix: add Node.js 16.x and 17.x to generated version link list #4545
Conversation
`source/nodejsVersions.md` is used to generate a list of version links on each locale page. Node.js 16.x and 17.x were missing.
|
16.x and 17.x are missing because those are the current versions already linked on the left nav and everywhere else. |
|
@Trott Thanks for the feedback. This makes sense to me. How about I close this PR and open a separate PR that adds a comment in |
|
@Trott Fwiw, I think it would be nice if the current versions showed up in the list alongside the other versions instead of having the distinction in the sidebar. It may not be the best phrasing currently though: I was going to recommend updating the phrasing to something that is less specific to other versions, but then the other locale docs would need to be updated 😅. |
|
@austinkelleher I'm fine with either of the options you suggest. I was just explaining why those two versions don't currently appear in there. Let's do whatever would be the best approach for end users. |
|
Thanks for the update @nschonni! |
|
Thanks @austinkelleher if you want to take more of a generated list approach/helper template, that might be another option to not need to bump this in the future |
|
@nschonni Good idea and I'm happy to work on this! 🔨 I think we should be able to leverage the information that is fetched from How does that sound to you? |
|
Sure, I think it might be a helper to put in https://github.com/nodejs/nodejs.org/tree/main/scripts/helpers and update the locale files too |
* Blog: Node.js 18 release announcement Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by: Ethan Arrowood <ethan@arrowood.dev> Co-authored-by: Matteo Collina <hello@matteocollina.com> Co-authored-by: Michael Dawson <mdawson@devrus.com> Co-authored-by: Michaël Zasso <targos@protonmail.com> Co-authored-by: Rich Trott <rtrott@gmail.com> Co-authored-by: Richard Lau <rlau@redhat.com> Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com> * Blog: v18.0.0 release post Refs: nodejs/node#42262 * fix: add Node.js 16.x and 17.x to generated version link list (nodejs#4545) * fix: add Node.js 16.x and 17.x to generated version link list `source/nodejsVersions.md` is used to generate a list of version links on each locale page. Node.js 17.x were missing. Co-authored-by: Nick Schonning <nschonni@gmail.com> * zh-CN: update site.json for Node.js 18 (nodejs#4554) Ref: nodejs#4553 * Fix typo (nodejs#4557) "to be trust" should be "to trust" as a transitive verb. * doc: update link about class features optimizations in Node.js 18 (nodejs#4556) There is a blog post explaining about this now, change the link. * doc: typo fix (nodejs#4558) Add missing "to" between the two verbs as a typo fix. * doc: fix wrong link for "windows" (nodejs#4514) The anchor to Windows installation session now points to "install nvs on Windows". This PR fixes the anchor to the correct location. * chore: replace callbacks with necessary async/await (nodejs#4555) 1. Some functions like 'fs' or 'graceFulFs' has been supporting 'async/await' for a long time, so this is a refactor to improve the related codes. 2. 'sass.render' is deprecated, use awaitable 'sass.compileAsync' instead. * Remove call to deprecated function util.inherits (nodejs#4483) * Remove call to deprecated function util.inherits * Update event-loop-timers-and-nexttick.md Co-authored-by: Rich Trott <rtrott@gmail.com> * Meetup sweden stockholm (nodejs#4407) Add the meetup for sweden stockholm. Co-authored-by: Beth Griggs <bgriggs@redhat.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by: Ethan Arrowood <ethan@arrowood.dev> Co-authored-by: Matteo Collina <hello@matteocollina.com> Co-authored-by: Michael Dawson <mdawson@devrus.com> Co-authored-by: Michaël Zasso <targos@protonmail.com> Co-authored-by: Rich Trott <rtrott@gmail.com> Co-authored-by: Richard Lau <rlau@redhat.com> Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com> Co-authored-by: Austin Kelleher <austinlkelleher@gmail.com> Co-authored-by: Nick Schonning <nschonni@gmail.com> Co-authored-by: Maledong <maledong_public@foxmail.com> Co-authored-by: Kenny <67985757+protofarer@users.noreply.github.com> Co-authored-by: Javad <79276645+Javad-93@users.noreply.github.com> Co-authored-by: Tse Kit Yam <tsekityam@users.noreply.github.com> Co-authored-by: Bart Louwers <bart.louwers@gmail.com> Co-authored-by: lxmarinkovic <lxmarinkovic@gmail.com>
source/nodejsVersions.mdis used to generate a list of version linkson each locale page. Node.js 16.x and 17.x were missing.
OLD: https://nodejs.org/en/docs/#looking-for-api-docs-of-previous-releases
NEW: