doc: enrich using-gc-traces #4775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cc @nodejs/diagnostics |
ovflowd
approved these changes
Aug 17, 2022
SEWeiTung
reviewed
Aug 19, 2022
| | startTime | The high-resolution millisecond timestamp is marking the starting time of the Performance Entry. | | ||
| | duration | The total number of milliseconds elapsed for this entry. | | ||
| | kind | The type of garbage collection operation that occurred. | | ||
| | flags | The high-resolution millisecond timestamp is marking the starting time of the Performance Entry. | |
There was a problem hiding this comment.
"flags"may be the meaning of "The additional info about GC"?
|
@tony-go: Sorry but catch it a bit later.....:( |
Nice catch, I probably miss something when I moved blocks in the doc. |
SEWeiTung
added a commit
that referenced
this pull request
Aug 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
Context
I recently wrote down a guide and pushed a PR on this repo.
As discussed in the recent meeting, it was probably not the best approach. We thought that it could be better to merge it with existing documentation.
Update
But we finally decided to extract a few parts from my work and inject it into the existing doc.