Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update process to become a collaborator #5441

Merged
merged 5 commits into from
Jun 19, 2023

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Jun 17, 2023

In order to make the process of becoming a collaborator more streamlined (and similar to the process of Node.js Core) this Pull Request makes changes to the Contributing Guidelines (and the Website Team chart) by changing how contributors might or might not become Collaborators.

cc @nodejs/website

Closes #5440

Signed-off-by: Claudio Wunder <cwunder@gnome.org>
@ovflowd ovflowd added the meta Meta Issues for Administration of the Website Team label Jun 17, 2023
@ovflowd ovflowd requested a review from a team as a code owner June 17, 2023 09:49
@vercel
Copy link

vercel bot commented Jun 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2023 8:22am
nodejs-org-stories ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2023 8:22am

Signed-off-by: Claudio Wunder <cwunder@gnome.org>
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories June 17, 2023 09:55 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org June 17, 2023 09:55 Inactive
Copy link
Contributor

@HinataKah0 HinataKah0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for clarifying

I found some other things we should fix in future PRs

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories June 17, 2023 17:34 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org June 17, 2023 17:34 Inactive
@ovflowd
Copy link
Member Author

ovflowd commented Jun 17, 2023

I've updated and reformatted the file

@ovflowd
Copy link
Member Author

ovflowd commented Jun 17, 2023

@bmuenzenmeyer and @HinataKah0 if you could update your suggestions/review based on my latest changes as I don't know if they're still relevant.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@bmuenzenmeyer
Copy link
Collaborator

if you could update your suggestions/review based on my latest changes as I don't know if they're still relevant.

Satisfied with the changes in the table of contents / structure 👍

Copy link
Contributor

@HinataKah0 HinataKah0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good!

Co-authored-by: Michael Esteban <mickel13@gmail.com>
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories June 18, 2023 13:42 Inactive
@ovflowd
Copy link
Member Author

ovflowd commented Jun 18, 2023

cc @nodejs/website as we need more approvals here :)

@vercel vercel bot temporarily deployed to Preview – nodejs-org June 18, 2023 13:43 Inactive
CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
@vercel vercel bot temporarily deployed to Preview – nodejs-org June 19, 2023 08:22 Inactive
@ovflowd
Copy link
Member Author

ovflowd commented Jun 19, 2023

I'm merging this as we got enough approvals. Thank you all!

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories June 19, 2023 08:22 Inactive
@ovflowd ovflowd merged commit 6496610 into main Jun 19, 2023
8 checks passed
@ovflowd ovflowd deleted the chore/change-nomination-process branch June 19, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Meta Issues for Administration of the Website Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Contribution Guide clarification
7 participants