Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove dependencies page and link to existing resource #5480

Merged
merged 5 commits into from
Jul 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TRANSLATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ If you're making a new Component and adding Translation Keys for your Component,

- Only add the new translation keys on the `i18n/locales/en.json` file. Crowdin will handle on syncing the files and letting translators know there are new keys to be translated
- The translation keys should have the prefix as the canonical path of your Component. If your Component is `components/Common/MyComponent` the prefix key should be `components.common.myComponent`
- The Translation Key suffix should be easy to undersand and semantic. For example, if the key is about "the text of a button that when interacted it copies content to the clipboard", the suffix should probably be `copyButton.title`. The final translation key would be `components.common.myComponent.copyButton.title`
- The Translation Key suffix should be easy to understand and semantic. For example, if the key is about "the text of a button that when interacted it copies content to the clipboard", the suffix should probably be `copyButton.title`. The final translation key would be `components.common.myComponent.copyButton.title`
- Translation Keys should be in Camel Case only.
- The values of each Translation Key should follow the [ICU Message Syntax](https://formatjs.io/docs/core-concepts/icu-syntax/)
- All new Translation keys should be added at the bottom of the `i18n/locales/en.json` file. Since this makes it easier for Translators to notice that there are new Translation keys to be translated.
Expand Down
10 changes: 5 additions & 5 deletions navigation.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,6 @@
"link": "/docs",
"translationId": "components.header.links.docs",
"items": {
"es6": {
"link": "/docs/es6",
"translationId": "components.navigation.docs.links.es6"
},
"apiLts": {
"link": "https://nodejs.org/dist/latest-{ltsNodeVersion}/docs/api",
"translationId": "components.navigation.docs.links.apiLts"
Expand All @@ -72,12 +68,16 @@
"link": "https://nodejs.org/dist/latest-{currentNodeVersion}/docs/api",
"translationId": "components.navigation.docs.links.apiCurrent"
},
"es6": {
"link": "/docs/es6",
"translationId": "components.navigation.docs.links.es6"
},
"guides": {
"link": "/docs/guides",
"translationId": "components.navigation.docs.links.guides"
},
"dependencies": {
"link": "/docs/meta/topics/dependencies",
"link": "https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-dependencies.md",
"translationId": "components.navigation.docs.links.dependencies"
}
}
Expand Down
78 changes: 0 additions & 78 deletions pages/ar/docs/meta/topics/dependencies.md

This file was deleted.

5 changes: 5 additions & 0 deletions pages/en/docs/index.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ There are several types of documentation available on this website:
- API reference documentation
- ES6 features
- Guides
- Dependencies

## API reference documentation

Expand All @@ -36,3 +37,7 @@ The [ES6 section](/en/docs/es6/) describes the three ES6 feature groups, and det
## Guides

The [Guides section](/en/docs/guides/) has long-form, in-depth articles about Node.js technical features and capabilities.

## Dependencies

Node.js depends on additional components beyond the Node.js code itself. These [dependencies](https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-dependencies.md) provide both native and JavaScript code and are built together with the code under the `src` and `lib` directories to create the Node.js binaries.
102 changes: 0 additions & 102 deletions pages/en/docs/meta/topics/dependencies.md

This file was deleted.

79 changes: 0 additions & 79 deletions pages/es/docs/meta/topics/dependencies.md

This file was deleted.

78 changes: 0 additions & 78 deletions pages/fr/docs/meta/topics/dependencies.md

This file was deleted.

Loading
Loading