Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added social icon LinkedIn, Issue #40 #5874

Merged
merged 3 commits into from
Sep 24, 2023

Conversation

srideviraju
Copy link
Contributor

@srideviraju srideviraju commented Sep 22, 2023

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@vercel
Copy link

vercel bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2023 9:43pm

@srideviraju srideviraju changed the title chore:Added social icon LinkedIn #40 chore: Added social icon LinkedIn, #issue 40 Sep 22, 2023
@srideviraju srideviraju changed the title chore: Added social icon LinkedIn, #issue 40 chore: Added social icon LinkedIn, Issue #40 Sep 22, 2023
Copy link
Contributor

@HinataKah0 HinataKah0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 1 minor comment.
Thank you for the contribution! 🎉

components/__design__/social-logos.stories.tsx Outdated Show resolved Hide resolved
Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.24% (185/205) 75% (30/40) 86.66% (39/45)

Unit Test Report

Tests Skipped Failures Errors Time
14 0 💤 0 ❌ 0 🔥 4.641s ⏱️

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying to use the GUI to fix this prettier issue

components/__design__/social-logos.stories.tsx Outdated Show resolved Hide resolved
Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
@bmuenzenmeyer
Copy link
Collaborator

thanks for your contribution to the project!

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Sep 24, 2023
Merged via the queue into nodejs:main with commit 944a672 Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants