Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Preview): add Preview component #6014

Merged
merged 5 commits into from
Oct 17, 2023
Merged

Conversation

junwen-k
Copy link
Contributor

Description

Add Preview component which renders the OpenGraph Image.

Validation

Added stories Preview component.

Announcement

image

Release

image

Vulnerability

image

Related Issues

Closes #6011

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@junwen-k junwen-k requested a review from a team as a code owner October 16, 2023 10:11
@vercel
Copy link

vercel bot commented Oct 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 2:59pm

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a clean implementation!

Thank you for your contribution! Super appreciate the effort here ✨

@ovflowd ovflowd added hacktoberfest This Issue is meant for Hacktoberfest 2023 github_actions:pull-request Trigger Pull Request Checks labels Oct 16, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 16, 2023
@github-actions
Copy link

github-actions bot commented Oct 16, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 96%
95.19% (297/312) 77.77% (56/72) 93.75% (60/64)

Unit Test Report

Tests Skipped Failures Errors Time
31 0 💤 0 ❌ 0 🔥 5.943s ⏱️

@junwen-k
Copy link
Contributor Author

@ovflowd Hi, I've actually went back and updated the ellipse to use radial gradient instead and I think the color looks slightly more natural now. It is not 100% pixel perfect with the original design but I think it looks close enough though 😄

Let me know if I should revert it if that is not preferred :)

@mikeesto
Copy link
Member

The build failure in CI doesn't seem related to this PR - currently Google fonts is timing out

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 17, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 17, 2023
@ovflowd ovflowd added this pull request to the merge queue Oct 17, 2023
Merged via the queue into nodejs:main with commit 7a99b73 Oct 17, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest This Issue is meant for Hacktoberfest 2023
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Preview Component
5 participants