Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: maintenance lts in the lack of active lts #6025

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Oct 18, 2023

Description

This PR fixes the missing LTS, as sometimes we only have a Maintenance LTS without having an Active LTS. This PR updates hooks and components to understand both of these items.

Validation

LTS sections should be working again

Related Issues

Fixes #6024

@ovflowd ovflowd added the fast-track Fast Tracking PRs label Oct 18, 2023
@ovflowd ovflowd requested a review from a team as a code owner October 18, 2023 08:40
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 18, 2023
@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Oct 18, 2023 8:40am

@ovflowd
Copy link
Member Author

ovflowd commented Oct 18, 2023

cc @nodejs/nodejs-website @nodejs/build @nodejs/releasers we need approvals here for fast-tracking this!

@github-actions
Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 94%
94.7% (286/302) 76.81% (53/69) 93.33% (56/60)

Unit Test Report

Tests Skipped Failures Errors Time
29 0 💤 0 ❌ 0 🔥 5.902s ⏱️

@ovflowd ovflowd disabled auto-merge October 18, 2023 08:56
@ovflowd ovflowd disabled auto-merge October 18, 2023 08:56
@ovflowd ovflowd merged commit fecdbb4 into main Oct 18, 2023
17 of 19 checks passed
@ovflowd ovflowd deleted the fix/maintenance-lts branch October 18, 2023 08:56
@bmuenzenmeyer
Copy link
Collaborator

thanks for hopping on this so fast - interesting that it's happened before

@ovflowd
Copy link
Member Author

ovflowd commented Oct 18, 2023

thanks for hopping on this so fast - interesting that it's happened before

Right, both on nodejs.dev, and nodejs.org (before Next.js migration). It is funny how we missed this (that's on me!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download (LTS) page not displaying
2 participants