Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update location of using-heap-snapshot.md #6029

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix: update location of using-heap-snapshot.md #6029

merged 1 commit into from
Oct 19, 2023

Conversation

emmanuel-ferdman
Copy link
Contributor

Description

PR fixes a broken link to using-heap-snapshot.md which was moved in PR #4991. Also it contains a few typo fixes.

Validation

Link points to a valid location.

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@emmanuel-ferdman emmanuel-ferdman requested a review from a team as a code owner October 19, 2023 11:22
@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 11:23am

@ovflowd ovflowd enabled auto-merge October 19, 2023 12:29
@github-actions
Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 94%
94.7% (286/302) 76.81% (53/69) 93.33% (56/60)

Unit Test Report

Tests Skipped Failures Errors Time
29 0 💤 0 ❌ 0 🔥 7.779s ⏱️

@ovflowd ovflowd added this pull request to the merge queue Oct 19, 2023
Merged via the queue into nodejs:main with commit 587b9e8 Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants