Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Syntax highlighter empty line #6055

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

canerakdas
Copy link
Member

Description

This PR aims to make empty lines visible again in syntax highlighter

Validation

image

Empty lines should shown in Vercel preview.

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@canerakdas canerakdas requested a review from a team as a code owner October 27, 2023 11:20
@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 11:21am

@github-actions
Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 94%
95% (304/320) 76.38% (55/72) 93.84% (61/65)

Unit Test Report

Tests Skipped Failures Errors Time
38 0 💤 0 ❌ 0 🔥 7.527s ⏱️

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, a valid hot fix for the old layout. I feel that for the new one, we might do the styling either directly on the Codebox component or... via AST.

@ovflowd
Copy link
Member

ovflowd commented Oct 27, 2023

cc @nodejs/nodejs-website as I'm fast-tracking this as a hot fix. Thank you for the fix, @canerakdas!

@ovflowd ovflowd added this pull request to the merge queue Oct 27, 2023
@ovflowd ovflowd added the fast-track Fast Tracking PRs label Oct 27, 2023
Merged via the queue into nodejs:main with commit ff41772 Oct 27, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants