Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of overflow-x: scroll in release page #609

Merged

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Mar 28, 2016

Hello :)

before

2016-03-28 22 23 00

## after

2016-03-28 22 22 39


I deleted this line(layouts/css/base.styl#L158) and then global pre has overflow-x: scroll.
I feel that I don't have any problem even if pre has the overflow-x: scroll at global.

in about page(IE11)
2016-03-28 18 06 46

check browsers

  • chrome
  • chromium
  • firefox
  • safari
  • IE11

Cheers!

@ghost
Copy link

ghost commented Mar 28, 2016

Travis build passed 👍

@lpinca
Copy link
Member

lpinca commented Mar 28, 2016

@abouthiroppy does scroll works on iOS? Asking because of this nodejs/node#5878.

@hiroppy
Copy link
Member Author

hiroppy commented Mar 29, 2016

@lpinca Thanks, I checked below:)

Simulator

  • iOS 8.2
  • iOS 9.2

actual machine

  • iOS 9.2

All device is iPhone6.

scroll-test

@lpinca
Copy link
Member

lpinca commented Mar 29, 2016

Tested it myself and can confirm that it works. LGTM.

@fhemberger fhemberger merged commit 1460305 into nodejs:master Mar 29, 2016
@fhemberger
Copy link
Contributor

Great, thank you! Merged.

@hiroppy hiroppy deleted the feature/modify-pre-css-in-release-page branch March 29, 2016 07:22
@hiroppy hiroppy mentioned this pull request Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants