-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adjust styles to match figmas and moved icons as react components #6143
feat: adjust styles to match figmas and moved icons as react components #6143
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lighthouse Results
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
Nope. That's why I made a PR, to let Chromatic analyse the divergences. You don't need to comment on the PR with the divergences, because Chromatic will already do that. |
@AugustinMauroy now you can review ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect ✨
NOTE: assets will no longer be served in public
I can see this leading to 404s with the org and elsewhere... Maybe that's by design |
These assets were never used anywhere to begin with. |
404 on https://github.com/nodejs/help perhaps that's an antipattern we want to stamp out. |
Well, these were added by us on the repo for redesign. They shouldn't have been used to begin with... You can use these: https://github.com/nodejs/nodejs.org/blob/main/README.md?plain=1#L8-L10 |
Description
This PR moves all our new SVG icons as React Components so they become directly part of the bundle.
This PR adjusts several styles and fixes a few Storybooks to match some styles that were not correctly defined as per Figma.
Finally this PR isolates global styles (
a, h1, h2, table,...
) as they're only used within Markdown content to be behind a pseudo.mdxContent
class name.Validation
Chromatic should look as close a possible; Storybook should build and work.