Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust styles to match figmas and moved icons as react components #6143

Merged
merged 8 commits into from
Nov 27, 2023

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Nov 25, 2023

Description

This PR moves all our new SVG icons as React Components so they become directly part of the bundle.

This PR adjusts several styles and fixes a few Storybooks to match some styles that were not correctly defined as per Figma.

Finally this PR isolates global styles (a, h1, h2, table,...) as they're only used within Markdown content to be behind a pseudo .mdxContent class name.

Validation

Chromatic should look as close a possible; Storybook should build and work.

@ovflowd ovflowd requested review from a team as code owners November 25, 2023 12:35
Copy link

vercel bot commented Nov 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2023 1:24pm

@ovflowd ovflowd added design website redesign Issue/PR part of the Node.js Website Redesign infrastructure Issues/PRs related to the Repository Infra github_actions:pull-request Trigger Pull Request Checks labels Nov 25, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 25, 2023
Copy link

github-actions bot commented Nov 25, 2023

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 95 🟢 97 🟢 92 🟢 92 🔗
/en/about 🟢 100 🟢 95 🟢 92 🟢 92 🔗
/en/about/previous-releases 🟢 98 🟢 93 🟢 92 🟢 92 🔗
/en/download 🟢 100 🟢 95 🟠 83 🟢 92 🔗
/en/blog 🟢 99 🟢 95 🟢 92 🟢 92 🔗

Copy link

github-actions bot commented Nov 25, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 94%
90.37% (366/405) 77.31% (92/119) 89.18% (66/74)

Unit Test Report

Tests Skipped Failures Errors Time
71 0 💤 0 ❌ 0 🔥 5.207s ⏱️

@AugustinMauroy

This comment was marked as resolved.

@ovflowd

This comment was marked as resolved.

@AugustinMauroy

This comment was marked as resolved.

@AugustinMauroy

This comment was marked as resolved.

@ovflowd

This comment was marked as off-topic.

@ovflowd ovflowd marked this pull request as draft November 25, 2023 13:00
@ovflowd
Copy link
Member Author

ovflowd commented Nov 25, 2023

is it on purpose?

Nope. That's why I made a PR, to let Chromatic analyse the divergences. You don't need to comment on the PR with the divergences, because Chromatic will already do that.

@ovflowd ovflowd marked this pull request as ready for review November 25, 2023 13:09
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Nov 25, 2023
@ovflowd
Copy link
Member Author

ovflowd commented Nov 25, 2023

@AugustinMauroy now you can review ;)

Copy link
Member

@canerakdas canerakdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

Copy link
Contributor

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect ✨
NOTE: assets will no longer be served in public

@ovflowd ovflowd added this pull request to the merge queue Nov 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Nov 27, 2023
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@ovflowd ovflowd added this pull request to the merge queue Nov 27, 2023
Merged via the queue into main with commit a7b2ca3 Nov 27, 2023
16 checks passed
@ovflowd ovflowd deleted the feat/isolate-global-styles-create-icon-components branch November 27, 2023 15:09
@bmuenzenmeyer
Copy link
Collaborator

Perfect ✨
NOTE: assets will no longer be served in public

I can see this leading to 404s with the org and elsewhere... Maybe that's by design

@ovflowd
Copy link
Member Author

ovflowd commented Nov 27, 2023

Perfect ✨
NOTE: assets will no longer be served in public

I can see this leading to 404s with the org and elsewhere... Maybe that's by design

These assets were never used anywhere to begin with.

@bmuenzenmeyer
Copy link
Collaborator

bmuenzenmeyer commented Nov 28, 2023

Perfect ✨
NOTE: assets will no longer be served in public

I can see this leading to 404s with the org and elsewhere... Maybe that's by design

These assets were never used anywhere to begin with.

404 on https://github.com/nodejs/help

perhaps that's an antipattern we want to stamp out.

@ovflowd
Copy link
Member Author

ovflowd commented Nov 28, 2023

Perfect ✨
NOTE: assets will no longer be served in public

I can see this leading to 404s with the org and elsewhere... Maybe that's by design

These assets were never used anywhere to begin with.

404 on nodejs/help

perhaps that's an antipattern we want to stamp out.

Well, these were added by us on the repo for redesign. They shouldn't have been used to begin with... You can use these: https://github.com/nodejs/nodejs.org/blob/main/README.md?plain=1#L8-L10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design infrastructure Issues/PRs related to the Repository Infra website redesign Issue/PR part of the Node.js Website Redesign
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants