-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use Next.js' way of adding webpack plugins #6149
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
removed
the
github_actions:pull-request
Trigger Pull Request Checks
label
Nov 30, 2023
Lighthouse Results
|
ovflowd
approved these changes
Nov 30, 2023
Thanks for the contribution! Super appreciate it 🎉 |
ovflowd
added
fast-track
Fast Tracking PRs
github_actions:pull-request
Trigger Pull Request Checks
labels
Nov 30, 2023
github-actions
bot
removed
the
github_actions:pull-request
Trigger Pull Request Checks
label
Nov 30, 2023
Thanks for the contribution! Super appreciate it 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next.js has a slightly different way it wants you to define webpack plugins (it actually would like you not to define any at all but w/e) and this seems necessary in order not to get webpack build warnings when using the DefinePlugin in some instances.