Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use Next.js' way of adding webpack plugins #6149

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Nov 30, 2023

Next.js has a slightly different way it wants you to define webpack plugins (it actually would like you not to define any at all but w/e) and this seems necessary in order not to get webpack build warnings when using the DefinePlugin in some instances.

@lforst lforst requested a review from a team as a code owner November 30, 2023 13:04
Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 1:10pm

@lforst lforst requested a review from a team as a code owner November 30, 2023 13:08
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Nov 30, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 30, 2023
Copy link

github-actions bot commented Nov 30, 2023

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 95 🟢 97 🟢 92 🟢 92 🔗
/en/about 🟢 100 🟢 95 🟢 92 🟢 92 🔗
/en/about/previous-releases 🟢 99 🟢 93 🟢 92 🟢 92 🔗
/en/download 🟢 100 🟢 95 🟢 92 🟢 92 🔗
/en/blog 🟢 100 🟢 95 🟢 92 🟢 92 🔗

Copy link

github-actions bot commented Nov 30, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 94%
90.37% (366/405) 77.31% (92/119) 89.18% (66/74)

Unit Test Report

Tests Skipped Failures Errors Time
71 0 💤 0 ❌ 0 🔥 4.647s ⏱️

@ovflowd
Copy link
Member

ovflowd commented Nov 30, 2023

Thanks for the contribution! Super appreciate it 🎉

@ovflowd
Copy link
Member

ovflowd commented Nov 30, 2023

Thanks for the contribution! Super appreciate it 🎉

@ovflowd ovflowd added this pull request to the merge queue Nov 30, 2023
Merged via the queue into nodejs:main with commit cbf9c41 Nov 30, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants