Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Layout max width #6174

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Conversation

canerakdas
Copy link
Member

Description

The maximum width given to the content area has been moved to the container area, ensuring that the layout does not shrink in cases where the width of the content width is low

Validation

image image

In cases where the content is long or short, the layout must comply with the maximum width(90rem/ 1440px) we have given and appear correct

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.

@canerakdas canerakdas requested a review from a team as a code owner December 2, 2023 17:12
Copy link

vercel bot commented Dec 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2023 5:14pm

Copy link

github-actions bot commented Dec 2, 2023

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 97 🟢 92 🟢 92 🔗
/en/about 🟢 100 🟢 95 🟢 92 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 93 🟢 92 🟢 92 🔗
/en/download 🟢 100 🟢 95 🟢 92 🟢 92 🔗
/en/blog 🟢 100 🟢 95 🟢 92 🟢 92 🔗

Copy link

github-actions bot commented Dec 2, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 94%
89.47% (374/418) 81.1% (103/127) 87.34% (69/79)

Unit Test Report

Tests Skipped Failures Errors Time
71 0 💤 0 ❌ 0 🔥 4.34s ⏱️

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the changes!

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Dec 2, 2023
Merged via the queue into nodejs:main with commit 38dc953 Dec 2, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants