Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(i18n): remove legacy key + rename #6389

Merged
merged 4 commits into from
Mar 4, 2024
Merged

chore(i18n): remove legacy key + rename #6389

merged 4 commits into from
Mar 4, 2024

Conversation

AugustinMauroy
Copy link
Contributor

Description

Remove all legacy i18n key before re-enable Crowdin.

Related Issues

No related issues.

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@AugustinMauroy AugustinMauroy requested review from a team as code owners March 2, 2024 08:35
Copy link

vercel bot commented Mar 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2024 11:08am

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Mar 2, 2024
@ovflowd
Copy link
Member

ovflowd commented Mar 2, 2024

LGTM! Looks good to me :)

Copy link

github-actions bot commented Mar 2, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 98 🟢 92 🟢 91 🔗
/en/about 🟢 100 🟢 98 🟢 92 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 96 🟢 92 🟢 92 🔗
/en/download 🟢 100 🟢 97 🟢 92 🟢 91 🔗
/en/blog 🟢 100 🟢 96 🟠 83 🟢 92 🔗

Copy link

github-actions bot commented Mar 2, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 85%
80.18% (433/540) 79.65% (137/172) 73.07% (76/104)

Unit Test Report

Tests Skipped Failures Errors Time
88 0 💤 0 ❌ 0 🔥 4.452s ⏱️

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Mar 2, 2024
@ovflowd

This comment was marked as outdated.

@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 2, 2024
@ovflowd ovflowd disabled auto-merge March 4, 2024 12:27
@ovflowd ovflowd merged commit a446e22 into main Mar 4, 2024
5 checks passed
@ovflowd ovflowd deleted the remove-i18n-key branch March 4, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants