-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #6404 : Version dropdown on download page doesn't scroll on overflow #6411
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lighthouse Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use css-module and tailwindcss.
Hello @AugustinMauroy, Thanks and Regards, |
… overflow (Updated v2)
Hello @AugustinMauroy, Thanks and Regards, |
I'd appreciate if you did not use AI/ChatGPT based solutions for generating your comments. |
Hello @ovflowd, Thanks and Regards, |
There's nothing to worry about! This is your first contribution, and we have a very strict guiding style which helps maintain the website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks for you first contribution 🎉
I'm requiring fast-tracking 'cause it's download page is difficult to use without this change. |
Description
Hello,
Hope you're doing well.
This PR has been raised to fix issue #6404, wherein the scroll down feature for versions doesn't work as it actually should.
In order to provide a fix for the same, I have added style property to the Primitive.Content component for which maxHeight and overflowY properties have been defined in the index.tsx file located at components/Common/Select.
Validation
In order to confirm if the scroll feature works as per requirement, I started the server locally and checked if the desired behaviour has been achieved or not.
Following are the screenshots of the updated dropdown component:
1)
If at all there are any changes required from my end, then do let me know.
Sincere apologies if I made any mistakes while resolving this issue and raising a PR for the same.
Related Issues
Fixes #6404
Check List
npx turbo lint
to ensure the code follows the style guide. And runnpx turbo lint:fix
to fix the style errors if necessary.npx turbo format
to ensure the code follows the style guide.npx turbo test
to check if all tests are passing.