Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6404 : Version dropdown on download page doesn't scroll on overflow #6411

Merged
merged 6 commits into from
Mar 4, 2024

Conversation

MohitKambli
Copy link
Contributor

Description

Hello,
Hope you're doing well.
This PR has been raised to fix issue #6404, wherein the scroll down feature for versions doesn't work as it actually should.
In order to provide a fix for the same, I have added style property to the Primitive.Content component for which maxHeight and overflowY properties have been defined in the index.tsx file located at components/Common/Select.

Validation

In order to confirm if the scroll feature works as per requirement, I started the server locally and checked if the desired behaviour has been achieved or not.
Following are the screenshots of the updated dropdown component:
1)
image

image

If at all there are any changes required from my end, then do let me know.
Sincere apologies if I made any mistakes while resolving this issue and raising a PR for the same.

Related Issues

Fixes #6404

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@MohitKambli MohitKambli requested a review from a team as a code owner March 3, 2024 08:19
Copy link

vercel bot commented Mar 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 3, 2024 8:14pm

Copy link

github-actions bot commented Mar 3, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🔴 69 🟢 96 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 96 🟢 100 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 95 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 95 🟢 100 🟢 91 🔗
/en/blog 🟢 98 🟢 92 🟢 100 🟢 92 🔗

Copy link

github-actions bot commented Mar 3, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 85%
80.18% (433/540) 79.65% (137/172) 73.07% (76/104)

Unit Test Report

Tests Skipped Failures Errors Time
88 0 💤 0 ❌ 0 🔥 4.467s ⏱️

Copy link
Contributor

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use css-module and tailwindcss.

@MohitKambli
Copy link
Contributor Author

Hello @AugustinMauroy,
I have made the necessary changes in the index.module.css file.
If at all there is something else that I need to do, then do let me know.
Sincere apologies for messing up in the previous commit and for my mistakes if you find any in the new commit.
Thank you so so much for understanding my part.

Thanks and Regards,
Mohit Kambli

@MohitKambli
Copy link
Contributor Author

Hello @AugustinMauroy,
As you had mentioned in the comments, I incorporated the code changes.
If at all there is something else required from my end, then do let me know.
Sincere apologies for the trouble being caused.

Thanks and Regards,
Mohit Kambli

@ovflowd
Copy link
Member

ovflowd commented Mar 3, 2024

Hello @AugustinMauroy, As you had mentioned in the comments, I incorporated the code changes. If at all there is something else required from my end, then do let me know. Sincere apologies for the trouble being caused.

Thanks and Regards, Mohit Kambli

I'd appreciate if you did not use AI/ChatGPT based solutions for generating your comments.

@MohitKambli
Copy link
Contributor Author

Hello @AugustinMauroy, As you had mentioned in the comments, I incorporated the code changes. If at all there is something else required from my end, then do let me know. Sincere apologies for the trouble being caused.
Thanks and Regards, Mohit Kambli

I'd appreciate if you did not use AI/ChatGPT based solutions for generating your comments.

Hello @ovflowd,
No, I don't use AI/ChatGPT at all to write my comments.
It has just become a habit of writing something like this after every mistake/commit I contribute to the Open Source Repositories.
That's just how I am.

Thanks and Regards,
Mohit Kambli

@AugustinMauroy
Copy link
Contributor

Sincere apologies for messing up in the previous commit and for my mistakes if you find any in the new commit.

There's nothing to worry about! This is your first contribution, and we have a very strict guiding style which helps maintain the website.

Copy link
Contributor

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for you first contribution 🎉

@AugustinMauroy AugustinMauroy added the fast-track Fast Tracking PRs label Mar 4, 2024
@AugustinMauroy
Copy link
Contributor

I'm requiring fast-tracking 'cause it's download page is difficult to use without this change.

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Mar 4, 2024
@ovflowd ovflowd enabled auto-merge March 4, 2024 12:30
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 4, 2024
@ovflowd ovflowd added this pull request to the merge queue Mar 4, 2024
Merged via the queue into nodejs:main with commit 69a332a Mar 4, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version dropdown on download page doesn't scroll on overflow
4 participants