Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pr-template): remove lint command and add build #6415

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

AugustinMauroy
Copy link
Contributor

Description

  • Remove lint because it's handle by format
  • Add build to recommended task
  • Add small explaining about checkbox in GFM

Related Issues

No related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@AugustinMauroy AugustinMauroy requested a review from a team as a code owner March 3, 2024 11:22
Copy link

vercel bot commented Mar 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 3, 2024 11:23am

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this attention to detail

@bmuenzenmeyer bmuenzenmeyer added the fast-track Fast Tracking PRs label Mar 3, 2024
@bmuenzenmeyer
Copy link
Collaborator

Fast tracking. This is small

@AugustinMauroy AugustinMauroy added the github_actions:pull-request Trigger Pull Request Checks label Mar 3, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 3, 2024
Copy link

github-actions bot commented Mar 3, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 96 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 96 🟢 100 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 95 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 95 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 92 🟢 100 🟢 92 🔗

Copy link

github-actions bot commented Mar 3, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 85%
80.18% (433/540) 79.65% (137/172) 73.07% (76/104)

Unit Test Report

Tests Skipped Failures Errors Time
88 0 💤 0 ❌ 0 🔥 4.606s ⏱️

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Mar 3, 2024
Merged via the queue into main with commit 1932563 Mar 3, 2024
21 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the chore(pull-request-template) branch March 3, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants