Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): added Persian (fa) lang #6421

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

mostafa-nematpour
Copy link
Contributor

Description

Added Persian to /i18n/config.json for internationalization.
I followed your steps to add it to crowdin

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@mostafa-nematpour mostafa-nematpour requested a review from a team as a code owner March 3, 2024 19:34
@AugustinMauroy
Copy link
Member

@ovflowd lang on crowdin is automaticly added or you need to add it manually ?

Copy link

vercel bot commented Mar 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 3, 2024 7:36pm

@ovflowd
Copy link
Member

ovflowd commented Mar 3, 2024

@ovflowd lang on crowdin is automaticly added or you need to add it manually ?

Need to add manually

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Mar 4, 2024
@ovflowd ovflowd enabled auto-merge March 4, 2024 12:28
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 4, 2024
Copy link
Contributor

github-actions bot commented Mar 4, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 96 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 96 🟢 100 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 95 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 95 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 92 🟢 100 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Mar 4, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 85%
80.18% (433/540) 79.65% (137/172) 73.07% (76/104)

Unit Test Report

Tests Skipped Failures Errors Time
88 0 💤 0 ❌ 0 🔥 4.405s ⏱️

@ovflowd ovflowd added this pull request to the merge queue Mar 4, 2024
Merged via the queue into nodejs:main with commit a3f6fd4 Mar 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants