Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(content): remove hbs from layout metadata #6436

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

AugustinMauroy
Copy link
Contributor

Description

Remove legacy .hbs because it dates back to the time when the site was built with metalsmith.

Validation

All page should render correctly

Related Issues

No related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • NA I've covered new added functionality with unit tests if necessary.

@AugustinMauroy AugustinMauroy requested review from a team as code owners March 4, 2024 14:37
Copy link

vercel bot commented Mar 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 4, 2024 2:38pm

This comment was marked as resolved.

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

What a big chonker.

Copy link

github-actions bot commented Mar 5, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 92 🟢 96 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 96 🟢 100 🟢 92 🔗
/en/about/previous-releases 🟢 99 🟢 95 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 95 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 96 🟢 100 🟢 92 🔗

Copy link

github-actions bot commented Mar 5, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 85%
80.18% (433/540) 79.65% (137/172) 73.07% (76/104)

Unit Test Report

Tests Skipped Failures Errors Time
88 0 💤 0 ❌ 0 🔥 4.448s ⏱️

@ovflowd
Copy link
Member

ovflowd commented Mar 5, 2024

I'm fast-tracking this as it is a "simple" change even tho it affects 1.3k files

@ovflowd ovflowd merged commit 0e15186 into main Mar 5, 2024
17 checks passed
@ovflowd ovflowd deleted the remove(hbs) branch March 5, 2024 10:49
@ovflowd ovflowd added the fast-track Fast Tracking PRs label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants