Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bg on LanguageDropDown #6449

Merged
merged 1 commit into from
Mar 5, 2024
Merged

fix: bg on LanguageDropDown #6449

merged 1 commit into from
Mar 5, 2024

Conversation

AugustinMauroy
Copy link
Contributor

Description

This pr solve same issue that transparent bg for header/footer. So it's just add bg for LanguageDropDown

Validation

before:

Capture d’écran 2024-03-05 à 16 38 27

After:

Capture d’écran 2024-03-05 à 16 40 19

Related Issues

No related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • NA I've covered new added functionality with unit tests if necessary.

@AugustinMauroy AugustinMauroy added design website redesign Issue/PR part of the Node.js Website Redesign labels Mar 5, 2024
@AugustinMauroy AugustinMauroy requested a review from a team as a code owner March 5, 2024 15:51
Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 5, 2024 3:51pm

Copy link

github-actions bot commented Mar 5, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 82 🟢 96 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 96 🟢 100 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 95 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 95 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 96 🟢 100 🟢 92 🔗

Copy link

github-actions bot commented Mar 5, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 85%
80.18% (433/540) 79.65% (137/172) 73.07% (76/104)

Unit Test Report

Tests Skipped Failures Errors Time
88 0 💤 0 ❌ 0 🔥 4.582s ⏱️

@ovflowd
Copy link
Member

ovflowd commented Mar 5, 2024

fast-tracking this a a simple fix!

@ovflowd ovflowd added this pull request to the merge queue Mar 5, 2024
Merged via the queue into main with commit b6dc35c Mar 5, 2024
27 checks passed
@ovflowd ovflowd deleted the fix-bg-language branch March 5, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design website redesign Issue/PR part of the Node.js Website Redesign
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants