Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Swedish locale in i18n config #6530

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

dinkelspiel
Copy link
Contributor

Description

Added swedish localization to the i18n/config.json so that translation work for swedish can begin.

Validation

Git diff shows added locale

Related Issues

No related issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@dinkelspiel dinkelspiel requested a review from a team as a code owner March 24, 2024 15:24
Copy link

vercel bot commented Mar 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 24, 2024 3:26pm

@dinkelspiel dinkelspiel changed the title Add Swedish locale in i18n config chore: Add Swedish locale in i18n config Mar 24, 2024
@bmuenzenmeyer bmuenzenmeyer added the i18n Issues/PRs related to the Website Internationalisation label Mar 25, 2024
@ovflowd
Copy link
Member

ovflowd commented Apr 11, 2024

FYI we're not adding new languages at the moment until we fix our Crowdin issues 🙇

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This work is now unblocked.

Copy link

github-actions bot commented Jun 15, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 90 🟢 96 🟢 91 🔗
/en/about 🟢 100 🟢 91 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 90 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟠 89 🟢 96 🟢 91 🔗
/en/blog 🟢 99 🟢 90 🟢 100 🟢 92 🔗

Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 84%
80.1% (451/563) 79.44% (143/180) 71.17% (79/111)

Unit Test Report

Tests Skipped Failures Errors Time
90 0 💤 0 ❌ 0 🔥 4.416s ⏱️

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Jun 15, 2024
Merged via the queue into nodejs:main with commit 7db2c19 Jun 15, 2024
16 of 18 checks passed
@bmuenzenmeyer
Copy link
Collaborator

added in crowdin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Issues/PRs related to the Website Internationalisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants