Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: add trip report of London 2024 summit #6653

Merged
merged 9 commits into from
Apr 15, 2024

Conversation

joyeecheung
Copy link
Member

Description

We discussed in the TSC and think that it would be a good idea to write a trip report for the London summit. This draft was previously reviewed by some of the summit participants. Expecting it to publish it next week.

cc @nodejs/tsc

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@joyeecheung joyeecheung requested a review from a team as a code owner April 12, 2024 21:35
Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 13, 2024 7:22pm

@joyeecheung
Copy link
Member Author

joyeecheung commented Apr 12, 2024

Looks like the deployment failed. I am scared to authorize Vercel to access my account and "Act on my behalf", so can't see the logs. If I sign up and log in using just my email, I see 404 when trying to inspect.

@AugustinMauroy
Copy link
Contributor

Looks like the deployment failed. I am scared to authorize Vercel to access my account and "Act on my behalf", so can't see the logs. If I sign up and log in using just my email, I see 404 when trying to inspect.

I'm deep diving. build also fail on my local.

@AugustinMauroy
Copy link
Contributor

The preview is available 🎉

Copy link

github-actions bot commented Apr 13, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 90 🟢 100 🟢 96 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 98 🟢 98 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 97 🟢 100 🟢 100 🟢 92 🔗

Copy link
Contributor

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on site.json there are an entry for websiteBadges it's a badge in the landing page. What do you think about having one for this blog post ?

Copy link

github-actions bot commented Apr 13, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 91%
90.1% (583/647) 76.08% (175/230) 92.12% (117/127)

Unit Test Report

Tests Skipped Failures Errors Time
128 0 💤 0 ❌ 0 🔥 5.612s ⏱️

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing it down!

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
@joyeecheung joyeecheung requested a review from a team as a code owner April 13, 2024 18:49
@joyeecheung
Copy link
Member Author

joyeecheung commented Apr 13, 2024

on site.json there are an entry for websiteBadges it's a badge in the landing page. What do you think about having one for this blog post ?

Updated, though I am not sure where the badge is displayed?

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
@joyeecheung
Copy link
Member Author

joyeecheung commented Apr 13, 2024

I added a few more finishing touches to things that still don't read quite right after looking at the preview....mostly grammer/wording fixes, except that I also added a bit more context about the standards-positions effort (that James proposed it, and added a link to the admin issue that proposed to create the repo).

@joyeecheung
Copy link
Member Author

(Oops, missed the M in James' name)

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Proceeding to merge this :)

@ovflowd ovflowd enabled auto-merge April 13, 2024 20:41
@joyeecheung
Copy link
Member Author

Thanks. Note that I set the publish date as 15 April (next Monday) I suppose it will only show up on the website on Monday? Or we can publicize it on Monday?

@ovflowd ovflowd disabled auto-merge April 13, 2024 20:45
@ovflowd
Copy link
Member

ovflowd commented Apr 13, 2024

No, it would come up immediately. Ive cancelled the auto merge. Let's merge on Monday then.

@joyeecheung
Copy link
Member Author

Let's wait until Monday, then (also in case there are other comments)

@AugustinMauroy
Copy link
Contributor

Updated, though I am not sure where the badge is displayed?

On landing page

@ovflowd ovflowd added this pull request to the merge queue Apr 15, 2024
Merged via the queue into nodejs:main with commit 0a5a934 Apr 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants