-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog: add trip report of London 2024 summit #6653
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Looks like the deployment failed. I am scared to authorize Vercel to access my account and "Act on my behalf", so can't see the logs. If I sign up and log in using just my email, I see 404 when trying to inspect. |
I'm deep diving. build also fail on my local. |
The preview is available 🎉 |
Lighthouse Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on site.json
there are an entry for websiteBadges
it's a badge in the landing page. What do you think about having one for this blog post ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing it down!
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
Updated, though I am not sure where the badge is displayed? |
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
I added a few more finishing touches to things that still don't read quite right after looking at the preview....mostly grammer/wording fixes, except that I also added a bit more context about the standards-positions effort (that James proposed it, and added a link to the admin issue that proposed to create the repo). |
(Oops, missed the M in James' name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Proceeding to merge this :)
Thanks. Note that I set the publish date as 15 April (next Monday) I suppose it will only show up on the website on Monday? Or we can publicize it on Monday? |
No, it would come up immediately. Ive cancelled the auto merge. Let's merge on Monday then. |
Let's wait until Monday, then (also in case there are other comments) |
On landing page |
Description
We discussed in the TSC and think that it would be a good idea to write a trip report for the London summit. This draft was previously reviewed by some of the summit participants. Expecting it to publish it next week.
cc @nodejs/tsc
Validation
Related Issues
Check List
npx turbo format
to ensure the code follows the style guide.npx turbo test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.