Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enables french locale #6837

Merged
merged 239 commits into from
Jun 14, 2024
Merged

enables french locale #6837

merged 239 commits into from
Jun 14, 2024

Conversation

bmuenzenmeyer
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer commented Jun 12, 2024

Description

Enables fr locale!
This is 100% translated and QA'd, and we think we've worked out the issues with the crowdin parser.

Validation

Review the french content translated per https://github.com/nodejs/nodejs.org/blob/main/crowdin.yml

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@bmuenzenmeyer bmuenzenmeyer requested a review from a team as a code owner June 12, 2024 22:25
Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 12, 2024 10:26pm

Copy link
Contributor

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I'm happy to enable French

Base automatically changed from chore/crowdin to main June 13, 2024 11:04
@bmuenzenmeyer bmuenzenmeyer added the github_actions:pull-request Trigger Pull Request Checks label Jun 13, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 13, 2024
Copy link

github-actions bot commented Jun 13, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 96 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 96 🟢 91 🔗
/en/about/previous-releases 🟢 98 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 96 🟢 92 🔗

Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.183s ⏱️

@bmuenzenmeyer bmuenzenmeyer changed the title adds french locale enables french locale Jun 13, 2024
@bmuenzenmeyer
Copy link
Collaborator Author

note - the real diff on this PR is only 96710a5 - the rest is a UI quirk of GitHub due to the target branch changing

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Jun 14, 2024
Merged via the queue into main with commit a8d7aa0 Jun 14, 2024
11 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the enable-fr branch June 14, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants