-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: footer missing on learn & about layout #6949
fix: footer missing on learn & about layout #6949
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@AugustinMauroy can you explain more what your concern is? I don't understand |
here's a split view of PROPOSED vs CURRENT The left nav no longer occupies the full vertical space, meaning someone may have to scroll to reach other content. Alternatively, the breadcrumb and Next/Previous buttons are still present. I am of the mindset this is acceptable to have the consistency of global elements throughout the site. |
@bmuenzenmeyer if i understood correctly below changes are required for |
No action needed on the Next/Previous buttons. I was remarking that there are already navigation aides on the site and IMO this PR is ready to merge as-is. We need to seek consensus when we disagree. @AugustinMauroy are your comments blocking? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT ! With re-review it's okay for me
thanks @rakeshkumar1019 for your work and patience here! |
Description
Added a footer to the Learn and About layouts, ensuring it appears as the natural last item in the scrolled content.
Related Issues
closes #6829
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.