Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: footer missing on learn & about layout #6949

Conversation

rakeshkumar1019
Copy link
Contributor

@rakeshkumar1019 rakeshkumar1019 commented Jul 26, 2024

Description

Added a footer to the Learn and About layouts, ensuring it appears as the natural last item in the scrolled content.

Related Issues

closes #6829

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 26, 2024 0:17am

Copy link
Member

@araujogui araujogui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AugustinMauroy
Copy link
Contributor

Capture d’écran 2024-08-22 à 17 17 51

im not fan of how the left nav is giving space by the content

@bmuenzenmeyer
Copy link
Collaborator

@AugustinMauroy can you explain more what your concern is? I don't understand

@bmuenzenmeyer
Copy link
Collaborator

here's a split view of PROPOSED vs CURRENT

image

The left nav no longer occupies the full vertical space, meaning someone may have to scroll to reach other content. Alternatively, the breadcrumb and Next/Previous buttons are still present. I am of the mindset this is acceptable to have the consistency of global elements throughout the site.

@rakeshkumar1019
Copy link
Contributor Author

here's a split view of PROPOSED vs CURRENT

image

The left nav no longer occupies the full vertical space, meaning someone may have to scroll to reach other content. Alternatively, the breadcrumb and Next/Previous buttons are still present. I am of the mindset this is acceptable to have the consistency of global elements throughout the site.

@bmuenzenmeyer if i understood correctly below changes are required
for left side navbar: it should have full height so user doesn't have the scroll up to reach other content.

for breadcrumb and Next/Previous buttons can you explain once again what exactly to be done ?

@bmuenzenmeyer
Copy link
Collaborator

for breadcrumb and Next/Previous buttons can you explain once again what exactly to be done ?

No action needed on the Next/Previous buttons. I was remarking that there are already navigation aides on the site and IMO this PR is ready to merge as-is. We need to seek consensus when we disagree. @AugustinMauroy are your comments blocking?

Copy link
Contributor

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT ! With re-review it's okay for me

Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.533s ⏱️

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Sep 10, 2024
@bmuenzenmeyer
Copy link
Collaborator

thanks @rakeshkumar1019 for your work and patience here!

Merged via the queue into nodejs:main with commit d8f851d Sep 10, 2024
11 checks passed
joeeames pushed a commit to joeeames/nodejs.org that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer missing on Learn layout
5 participants