fix(action): correct lint path, clean up warnings, fix lints #7043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
we also get cb1a961 addresses this |
bmuenzenmeyer
changed the title
ovflowd
reviewed
Sep 13, 2024
ovflowd
approved these changes
Sep 13, 2024
github-actions
bot
removed
the
github_actions:pull-request
Unit Test Coverage Report
Unit Test Report
|
AugustinMauroy
approved these changes
Sep 14, 2024
aymen94
approved these changes
Sep 16, 2024
joeeames
pushed a commit
to joeeames/nodejs.org
that referenced
this pull request
Sep 24, 2024
…7043) * fix(action): supply config path * fix(eslint): supply custom path to pages * fix(eslint): replace deprecated ignore approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/nodejs/nodejs.org/actions/runs/10850360175/job/30111620392 failed due to incorrect eslint configuration/invocation
Validation
⬆️ succeeds now
A cleaned up and rebased #7040 should succeed
Related Issues
supports #7040 cleanly
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.