Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: add Upcoming CVE for EOL Versions post #7328

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

RafaelGSS
Copy link
Member

Refs: nodejs/security-wg#1401

cc: @nodejs/tsc @nodejs/security-wg @nodejs/security

@RafaelGSS RafaelGSS requested a review from a team as a code owner December 12, 2024 14:17
Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 24, 2024 1:01am

@RafaelGSS
Copy link
Member Author

Please, do not land it until the TSC team reviews that.

@richardlau
Copy link
Member

Should we mention the OpenJS Ecosystem Sustainability Program for the End-of-Life releases?
https://nodejs.org/en/about/previous-releases#commercial-support

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RafaelGSS RafaelGSS removed the blocked label Dec 20, 2024
@RafaelGSS
Copy link
Member Author

PTAL @nodejs/tsc

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.79% (631/695) 72.44% (184/254) 94.53% (121/128)

Unit Test Report

Tests Skipped Failures Errors Time
143 0 💤 0 ❌ 0 🔥 5.169s ⏱️

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RafaelGSS
Copy link
Member Author

RafaelGSS commented Dec 23, 2024

@nodejs/nodejs-website If I merge this the blog post will be published or will it respect the date set in the markdown?

@AugustinMauroy
Copy link
Member

It will be publish and mention the date you had put on md

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a suggested wording change.

…sions.md

Co-authored-by: Michael Dawson <mdawson@devrus.com>
Signed-off-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants