Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bithound.metalsmith stylus.2.0.0 #821

Closed
wants to merge 3 commits into from
Closed

Bithound.metalsmith stylus.2.0.0 #821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f03775
fix: package.json & .snyk to reduce vulnerabilities
Jul 8, 2016
3cf483d
Merge pull request #1 from NubleX/snyk-fix-3e38e2de
NubleX Jul 8, 2016
415cc1f
update metalsmith-stylus to 2.0.0
bithoundio Jul 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .snyk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
version: v1.5.0
ignore: {}
patch:
'npm:marked:20150520':
- marked:
patched: '2016-07-08T18:27:48.890Z'
- metalsmith-markdown > marked:
patched: '2016-07-08T18:27:48.890Z'
'npm:minimatch:20160620':
- metalsmith-collections > minimatch:
patched: '2016-07-08T18:27:48.890Z'
- metalsmith-stylus > minimatch:
patched: '2016-07-08T18:27:48.890Z'
- metalsmith > recursive-readdir > minimatch:
patched: '2016-07-08T18:27:48.890Z'
- metalsmith-stylus > stylus > glob > minimatch:
patched: '2016-07-08T18:27:48.890Z'
16 changes: 10 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@
"test": "npm run test:lint && npm run test:unit && npm run test:smoke",
"test:lint": "standard",
"test:unit": "tape tests/**/*.test.js | faucet",
"test:smoke": "tape tests/*.smoketest.js | faucet"
"test:smoke": "tape tests/*.smoketest.js | faucet",
"snyk-protect": "snyk protect",
"prepublish": "npm run snyk-protect"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Website is not published to npm, so it should be

-    "snyk-protect": "snyk protect",
-    "prepublish": "npm run snyk-protect"
+    "postinstall": "snyk protect"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't prepublish always run after install?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thealphanerd not always, but most times:
screen shot 2016-07-09 at 23 32 30

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the intention is better understandable with 'postinstall', even if 'prepublish' might work as well.

},
"repository": {
"type": "git",
Expand All @@ -35,7 +37,7 @@
"changelog-url": "1.0.2",
"cheerio": "0.19.0",
"chokidar": "1.2.0",
"handlebars": "4.0.4",
"handlebars": "4.0.5",
"html-to-text": "^1.5.0",
"js-yaml": "^3.4.5",
"junk": "1.0.2",
Expand All @@ -49,16 +51,17 @@
"metalsmith-metadata": "0.0.2",
"metalsmith-permalinks": "0.4.0",
"metalsmith-prism": "2.1.1",
"metalsmith-stylus": "1.0.0",
"metalsmith-stylus": "^2.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should be in another pr

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for "Update dependencies" PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metalsmith-stylus is already at version 2.0.0 on master.
Some other dependencies updated here are also already updated on master.

"metalsmith-yearly-pagination": "2.0.0",
"ncp": "2.0.0",
"node-geocoder": "^3.4.1",
"node-version-data": "1.0.0",
"octonode": "0.7.4",
"octonode": "0.7.6",
"request": "^2.67.0",
"require-dir": "0.3.0",
"semver": "5.0.3",
"st": "1.0.0",
"snyk": "^1.17.0",
"st": "1.1.0",
"strftime": "0.9.2"
},
"devDependencies": {
Expand All @@ -68,5 +71,6 @@
"proxyquire": "^1.7.3",
"standard": "^6.0.8",
"tape": "^4.2.2"
}
},
"snyk": true
}