Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Interactive US banner with Dec 2nd date #898

Merged
merged 1 commit into from
Sep 23, 2016
Merged

Update Interactive US banner with Dec 2nd date #898

merged 1 commit into from
Sep 23, 2016

Conversation

williamkapke
Copy link
Contributor

Fixes #870

@williamkapke
Copy link
Contributor Author

Hm, looks like the current one has some transparency and the new one doesn't. I'll see if I can modify it.

@williamkapke
Copy link
Contributor Author

I couldn't modify it myself. Cassandra has asked for an updated one- which she'll relay to me.

@williamkapke
Copy link
Contributor Author

Ok- pushed the latest they sent me. It seems a bit different...? The color is off :/

With @phillipj 's #909 this might not make a difference. Some please tell me if I need to go back and ask for another version or merge it!

phillipj
phillipj approved these changes Sep 22, 2016
View reviewed changes
Copy link
Member

@phillipj phillipj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as you said the slight brightness difference will not be an issue with the EU banner removed

lpinca
lpinca approved these changes Sep 22, 2016
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once #909 is merged.

@lpinca lpinca merged commit b067e72 into master Sep 23, 2016
@lpinca lpinca deleted the interactive_logo branch September 23, 2016 07:12
@phillipj
Copy link
Member

Thanks for pinging the right people and fixing this @williamkapke 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipj phillipj phillipj approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@williamkapke @phillipj @lpinca