Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on contents for a package maintenance team "issue template" #265

Closed
Emuentes opened this issue Oct 8, 2019 · 4 comments
Closed
Assignees
Labels
good first issue Good for newcomers pull request wanted Create a PR from the discussion

Comments

@Emuentes
Copy link
Contributor

Emuentes commented Oct 8, 2019

Some tickets have lingered due to lack of consensus or clarity on the outcome that would justify the closing of the ticket.

In an effort to enable the team to confidently close tickets (or break them down into smaller scope, easier to manage parts) let's create an issue template to help streamline discussion practices.

@Emuentes Emuentes changed the title Create an issue template Decide on contents for a package maintenance team "issue template" Oct 8, 2019
@Emuentes Emuentes added discussion The decision process is still ongoing package-maintenance-agenda Agenda items for package-maintenance team labels Oct 8, 2019
@Eomm
Copy link
Member

Eomm commented Oct 9, 2019

It is not clear to me if the issue template is a GitHub issue template that will be shown to the users that will open a new issue or the scope is to write down some shared rules in the contribution.md?

In an effort to enable the team to confidently close tickets

I agree, also for merging PR.

I would list these points

Merging PR:

  • at least 4 approval
  • no blocking review
  • merge after X days of the last approval

Close issue:

  • summarize the content and close (open other issues if necessary)

@mhdawson
Copy link
Member

In terms of merging a PR, in core we only require 2 approvals and 48 hours. Something longer is probably appropriate here as its not code, but processes, policies etc but I'd say some like:

  • at least 2 approvals
  • no blocking review
  • 7 days from time PR was opened.

@mhdawson
Copy link
Member

mhdawson commented Nov 5, 2019

Discussed in last meeting. This is what we agreed to be:

Least 4 approvals
No blocking review
7 days from time 4th approval was received.

Next step is to PR into README.md

@mhdawson mhdawson removed the package-maintenance-agenda Agenda items for package-maintenance team label Nov 5, 2019
@Eomm Eomm added pull request wanted Create a PR from the discussion and removed discussion The decision process is still ongoing labels Nov 5, 2019
ghinks added a commit that referenced this issue Nov 7, 2019
Pull Request Merging policy from issue [265](#265) describing the requirements
for a PR to be merged.
@ghinks
Copy link
Contributor

ghinks commented Nov 8, 2019

The rules above we added under PR #279
Now we have the rule in master we can close this in the next meeting.

@ghinks ghinks closed this as completed Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers pull request wanted Create a PR from the discussion
Projects
None yet
Development

No branches or pull requests

4 participants