-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decide on contents for a package maintenance team "issue template" #265
Comments
It is not clear to me if the
I agree, also for merging PR. I would list these points Merging PR:
Close issue:
|
In terms of merging a PR, in core we only require 2 approvals and 48 hours. Something longer is probably appropriate here as its not code, but processes, policies etc but I'd say some like:
|
Discussed in last meeting. This is what we agreed to be: Least 4 approvals Next step is to PR into README.md |
Pull Request Merging policy from issue [265](#265) describing the requirements for a PR to be merged.
The rules above we added under PR #279 |
Some tickets have lingered due to lack of consensus or clarity on the outcome that would justify the closing of the ticket.
In an effort to enable the team to confidently close tickets (or break them down into smaller scope, easier to manage parts) let's create an issue template to help streamline discussion practices.
The text was updated successfully, but these errors were encountered: